Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation for _metadata feature #785

Closed
thjaeckle opened this issue Sep 3, 2020 · 7 comments
Closed

Provide documentation for _metadata feature #785

thjaeckle opened this issue Sep 3, 2020 · 7 comments

Comments

@thjaeckle
Copy link
Member

Was not done as part of #680, so must still be done.

@JulianFeinauer
Copy link
Contributor

@thjaeckle and @jufickel-b I started to work on the documentation in this branch: https://github.com/JulianFeinauer/ditto/tree/feature/785-documentation-metadata do you agree with the current setup?

@thjaeckle
Copy link
Member Author

thjaeckle commented Sep 7, 2020

@JulianFeinauer cool - I just had a brief look.

  • adding it as a new page is good - as it is a new concept
  • then you also must add it to the _data/sidebards/ditto_sidebar.yml or else it won't show in the navigation
  • the current implementation does not have any predefined metadata, even not issuedAt - so that one also is not implicitly set

I'm not sure if that will work:

{
  "key":"*/",
  "value":{"issuedAt": someTimestamp }
}

I would have expected to look like:

{
  "key": "*/issuedAt",
  "value": someTimestamp
}

@JulianFeinauer
Copy link
Contributor

Hey @thjaeckle thanks for the feedback.. I did not finish it the weekent because I wanted to sit down and try it out myself as I did not track all changes you and @jufickel-b did in the code so before submitting it as PR I will try to test it.

@jufickel-b
Copy link

@thjaeckle your expectation is correct.
@JulianFeinauer you can have a look at the unit tests to see the format of metadata headers: DefaultMetadataHeaderTest

@w4tsn
Copy link
Contributor

w4tsn commented Sep 14, 2020

This not only needs to be added to the doc pages but also to the swagger docs.

@jufickel-b so I suppose that all complex json objects have to be broken down such that I get one array entry for each leaf. E.g. the issuedBy example from the docs proposal would have to be split up into two entries, correct?

@w4tsn
Copy link
Contributor

w4tsn commented Sep 14, 2020

The API example / specification under basic-thing.md needs to be updated to.

In the current docs: https://www.eclipse.org/ditto/basic-thing.html

JulianFeinauer added a commit to JulianFeinauer/ditto that referenced this issue Sep 16, 2020
…ure (eclipse-ditto#680).

Corrections in basic-metadata.md and added changes to ditto-api-2.yml-Swagger Doc.

Signed-off-by: julian <[email protected]>
thjaeckle added a commit to JulianFeinauer/ditto that referenced this issue Sep 21, 2020
* fixed JsonSchema for Thing + Swagger
* added link from basic-thing.md to metadata page
* added metadata page to sidebar
* fixed/adjusted some documentation + added more complete examples

Signed-off-by: Thomas Jaeckle <[email protected]>
thjaeckle pushed a commit that referenced this issue Sep 23, 2020
Corrections in basic-metadata.md and added changes to ditto-api-2.yml-Swagger Doc.

Signed-off-by: julian <[email protected]>
thjaeckle added a commit that referenced this issue Sep 23, 2020
* fixed JsonSchema for Thing + Swagger
* added link from basic-thing.md to metadata page
* added metadata page to sidebar
* fixed/adjusted some documentation + added more complete examples

Signed-off-by: Thomas Jaeckle <[email protected]>
@thjaeckle
Copy link
Member Author

Closed via merged #806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants