-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide documentation for _metadata feature #785
Comments
@thjaeckle and @jufickel-b I started to work on the documentation in this branch: https://github.com/JulianFeinauer/ditto/tree/feature/785-documentation-metadata do you agree with the current setup? |
@JulianFeinauer cool - I just had a brief look.
I'm not sure if that will work: {
"key":"*/",
"value":{"issuedAt": someTimestamp }
} I would have expected to look like: {
"key": "*/issuedAt",
"value": someTimestamp
} |
Hey @thjaeckle thanks for the feedback.. I did not finish it the weekent because I wanted to sit down and try it out myself as I did not track all changes you and @jufickel-b did in the code so before submitting it as PR I will try to test it. |
@thjaeckle your expectation is correct. |
This not only needs to be added to the doc pages but also to the swagger docs. @jufickel-b so I suppose that all complex json objects have to be broken down such that I get one array entry for each leaf. E.g. the issuedBy example from the docs proposal would have to be split up into two entries, correct? |
The API example / specification under basic-thing.md needs to be updated to. In the current docs: https://www.eclipse.org/ditto/basic-thing.html |
…ure (eclipse-ditto#680). Corrections in basic-metadata.md and added changes to ditto-api-2.yml-Swagger Doc. Signed-off-by: julian <[email protected]>
* fixed JsonSchema for Thing + Swagger * added link from basic-thing.md to metadata page * added metadata page to sidebar * fixed/adjusted some documentation + added more complete examples Signed-off-by: Thomas Jaeckle <[email protected]>
Corrections in basic-metadata.md and added changes to ditto-api-2.yml-Swagger Doc. Signed-off-by: julian <[email protected]>
* fixed JsonSchema for Thing + Swagger * added link from basic-thing.md to metadata page * added metadata page to sidebar * fixed/adjusted some documentation + added more complete examples Signed-off-by: Thomas Jaeckle <[email protected]>
Closed via merged #806 |
Was not done as part of #680, so must still be done.
The text was updated successfully, but these errors were encountered: