Update preprocessing notebook

[SarahAlidoost]

closes #68 closes #162 closes #165 relates eWaterCycle/ewatercycle-lisflood#11 closes #176

Docs preview: https://ewatercycle--163.org.readthedocs.build/en/163/examples/generate_forcing.html

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Peter9192]

Notebook looks good. Some additional suggestions that would make it even nicer:

• The notebooks doesn't include Marrmot or hype. Did we decide to skip those?
• Perhaps add a very short description to each model, something like: "Forcing for the PCRGlobWB is created using the ESMValTool recipe . It produces two files: one for temperature and one for precipitation. You can set the start and end date, and the region. See for more information.
• How difficult would it be to actually use the shapefiles in the plotting routines?
• Even more bonus: we now have plot codes for these models. Why not move them to methods in the forcing classes? So you could do WflowForcing.plot() :-)
• I might still make some changes to the PCRGlobWB generate function as discussed earlier today. Hope it won't cause too much trouble.

Also thanks a lot for fixing all the additional minor issues in the process!

[SarahAlidoost]

Notebook looks good. Some additional suggestions that would make it even nicer:

• The notebooks doesn't include Marrmot or hype. Did we decide to skip those?

Marrmot generate forcing is implemented in case-1 technical notebook. I don't recall the reason why we skip the hype. 🤔 Shall we add it?

• Perhaps add a very short description to each model, something like: "Forcing for the PCRGlobWB is created using the ESMValTool recipe . It produces two files: one for temperature and one for precipitation. You can set the start and end date, and the region. See for more information.

it is added for each model.

• How difficult would it be to actually use the shapefiles in the plotting routines?
• Even more bonus: we now have plot codes for these models. Why not move them to methods in the forcing classes? So you could do WflowForcing.plot() :-)

I think plotting is a new feature and not in the scope of this PR. If it is OK let's not implement it in this PR and before the release. Let's leave some work for after release. 😄

• I might still make some changes to the PCRGlobWB generate function as discussed earlier today. Hope it won't cause too much trouble.

Shall we make a new item and PR for that?

Also thanks a lot for fixing all the additional minor issues in the process!

Thank you for reviewing and comments on nbreview.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.0% Coverage
0.0% Duplication

[Peter9192]

Thanks Sarah!
We decided to do Hype later.