Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lisflood generate forcing needs an argument to run lisvap #11

Open
SarahAlidoost opened this issue Jul 12, 2021 · 2 comments
Open

lisflood generate forcing needs an argument to run lisvap #11

SarahAlidoost opened this issue Jul 12, 2021 · 2 comments

Comments

@SarahAlidoost
Copy link

The current LisfloodForcing returns an error due to the lisvap output. The generate function needs a boolean argument to ask whether lisvap should be run.
@SarahAlidoost
Copy link
Author

so, when for example run_lisvap = False, Lisflood forcing should return none for lisvap output. Therefore, the default values for those outputs should be removed from init.

@SarahAlidoost SarahAlidoost mentioned this issue Jul 12, 2021
Merged
@SarahAlidoost
Copy link
Author

The first comment is addressed in PR eWaterCycle/ewatercycle#163. The second comment needs more design sessions when addressing issue eWaterCycle/ewatercycle#96.

@sverhoeven sverhoeven mentioned this issue Sep 3, 2021
Open
@BSchilperoort BSchilperoort transferred this issue from eWaterCycle/ewatercycle Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SarahAlidoost