Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path consistent #143

Merged
merged 33 commits into from
Jul 8, 2021
Merged

Make path consistent #143

merged 33 commits into from
Jul 8, 2021

Commits on Jul 6, 2021

  1. add to_absolute_path to util and its tests

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    d36261c View commit details
    Browse the repository at this point in the history

  2. implemet to_absolute_path for forcing and parameterset

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    11f7f18 View commit details
    Browse the repository at this point in the history

  3. try to refactor forcing load

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    604601a View commit details
    Browse the repository at this point in the history

  4. remove shape from the content of yml file of forcing object

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    a5ae91a View commit details
    Browse the repository at this point in the history

  5. refactor forcing load

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    f60274d View commit details
    Browse the repository at this point in the history

  6. replace r with s in repr and str methods of parameter_sets

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    58b8c7c View commit details
    Browse the repository at this point in the history

  7. add str method to model abstract and forcing default

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    2965460 View commit details
    Browse the repository at this point in the history

  8. apply to_absolute_path to wflow forcing and model

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    ed0b02d View commit details
    Browse the repository at this point in the history

  9. fix test repr and str in parameter_sets

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    cc637d4 View commit details
    Browse the repository at this point in the history

  10. apply to_absolute_path to pcrglob model

    @SarahAlidoost
    SarahAlidoost committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    c11a059 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. apply to_absolute_path for marrmot model

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    55adcdc View commit details
    Browse the repository at this point in the history

  2. apply to_absolute_path for lisflood model

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    e671afa View commit details
    Browse the repository at this point in the history

  3. remove unused import from wflow forcing

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    71b4a9b View commit details
    Browse the repository at this point in the history

  4. apply to_absolute_path on grdc

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    1f262d0 View commit details
    Browse the repository at this point in the history

  5. apply to_absolute_path on config object

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    7d1ac07 View commit details
    Browse the repository at this point in the history

  6. add str around input_path in test 

    Co-authored-by: Stefan Verhoeven <[email protected]>
    @SarahAlidoost @sverhoeven
    SarahAlidoost and sverhoeven authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    4327074 View commit details
    Browse the repository at this point in the history

  7. add additional test for to_absolute_path 

    Co-authored-by: Stefan Verhoeven <[email protected]>
    @SarahAlidoost @sverhoeven
    SarahAlidoost and sverhoeven authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    4d1c087 View commit details
    Browse the repository at this point in the history

  8. Use strict argument in resolve function 

    Co-authored-by: Stefan Verhoeven <[email protected]>
    @SarahAlidoost @sverhoeven
    SarahAlidoost and sverhoeven authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    3ad90c1 View commit details
    Browse the repository at this point in the history

  9. revise docstring in to_absolute_path

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    d130fc2 View commit details
    Browse the repository at this point in the history

  10. fix mypy error on config object

    @SarahAlidoost
    SarahAlidoost committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    6ef64c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. add a new test for to_absolute_path

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a3ebddf View commit details
    Browse the repository at this point in the history

  2. use to_absolute_path(cfg_dir) in lisflood and marrmot

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    f02e713 View commit details
    Browse the repository at this point in the history

  3. fix shape in forcing and add extra tests

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    afc087f View commit details
    Browse the repository at this point in the history

  4. remove is_relative_to

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d16a463 View commit details
    Browse the repository at this point in the history

  5. add fiona to doc req.

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    aa64b7e View commit details
    Browse the repository at this point in the history

  6. refactor str method in abstract as Peter suggested 

    Co-authored-by: Peter Kalverla <[email protected]>
    @SarahAlidoost @Peter9192
    SarahAlidoost and Peter9192 authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e15c94e View commit details
    Browse the repository at this point in the history

  7. add test for str method in marrmot

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    325550d View commit details
    Browse the repository at this point in the history

  8. add textwrap.indent in str method of abstract class

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d442eba View commit details
    Browse the repository at this point in the history

  9. remove space before assignment

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    eaa426b View commit details
    Browse the repository at this point in the history

  10. add a test for str, fix parameterset_dir in mocked CFG

    @SarahAlidoost
    SarahAlidoost committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a97eaaa View commit details
    Browse the repository at this point in the history

  11. Hard code version instead of importing

    @sverhoeven
    sverhoeven committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    8757ab8 View commit details
    Browse the repository at this point in the history

  12. Fix str tests

    @sverhoeven
    sverhoeven committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    33afb56 View commit details
    Browse the repository at this point in the history

  13. Add link to Path in docstring + added intersphinx 

    Refs #43
    @sverhoeven
    sverhoeven committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5ed4a31 View commit details
    Browse the repository at this point in the history