Make path consistent #143
Merged
Make path consistent #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverhoeven
requested changes
Jul 7, 2021
There was a problem hiding this comment.
I searched for usage of expanduser and resolve and it is now only used in ewatercycle/util.py:to_absolute_path, in ewatercycle/config/_config_object.py:load_from_file and in ewatercycle/observation/grdc.py:get_grdc_data . Can Config.load_from_file and the grdc be changed to also use to_absolute_path()?
I searched for Path constructor and mostly shows up in util.py.
This PR has a lot of smart replacements. Nice work.
See inline questions and suggestions.
Peter9192
reviewed
Jul 7, 2021
Co-authored-by: Stefan Verhoeven <[email protected]>
Co-authored-by: Stefan Verhoeven <[email protected]>
Co-authored-by: Stefan Verhoeven <[email protected]>
Co-authored-by: Peter Kalverla <[email protected]>
sverhoeven
approved these changes
Jul 8, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Thanks for reviewing, nice comments, and pair-programming. |
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93
after merging this, close PR #107