-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #461 hovmoeller tests #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version of the scatter plot is no longer useful, it has been refactored, using matplotlib and is pending further instructions. Work is in the feature_23_scatter feature branch, and user documentation on read the docs: https://metplotpy.readthedocs.io/en/feature_23_scatter/Users_Guide/scatter.html
The new scatter plot's imports are consistent with the suggested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't be necessary, a new config file corresponding to the refactored scatter plot will replace this config file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scatter plot changes aren't necessary, as the scatter plot will be replaced by the refactored version in feature_23_scatter
NOTE - this is built on top of #465. This PR should go in after, or instead of, #465.
In this PR
Pull Request Testing
Describe testing already performed for these changes:
Tests run
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
No
Do these changes include sufficient testing updates? [Yes or No]
yes
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
yes - more tests will run
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases