Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test infrastructure and coverage #461

Closed
1 of 25 tasks
John-Sharples opened this issue Sep 16, 2024 · 0 comments · Fixed by #462, #463, #467, #466 or #464
Closed
1 of 25 tasks

Improve unit test infrastructure and coverage #461

John-Sharples opened this issue Sep 16, 2024 · 0 comments · Fixed by #462, #463, #467, #466 or #464
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: testing Software testing issue METplotpy: General type: enhancement Improve something that it is currently doing

Comments

@John-Sharples
Copy link

Describe the Enhancement

Improve how the tests are invoked and run. Add a conftest.py file and use this for common fixtures and setup.

Time Estimate

~ 4 weeks

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • create conftest
  • get all tests running from simple pytest call
  • improve tests coverage

Relevant Deadlines

By end of @John-Sharples visitor project

Funding Source

Visitor program

Define the Metadata

Assignee

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplotpy-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplotpy-X.Y.Z version, select the METplotpy-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplotpy-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@John-Sharples John-Sharples added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: testing Software testing issue METplotpy: General labels Sep 16, 2024
@John-Sharples John-Sharples added this to the METplotpy-3.0.0 milestone Sep 16, 2024
@John-Sharples John-Sharples linked a pull request Sep 18, 2024 that will close this issue
15 tasks
bikegeek pushed a commit that referenced this issue Sep 18, 2024
* 461: move to pyproject.toml for build

* 461: update docs and sonarQube
@John-Sharples John-Sharples linked a pull request Sep 20, 2024 that will close this issue
15 tasks
@bikegeek bikegeek moved this to 🏗 In progress in METplus-Analysis-6.0.0 Development Sep 20, 2024
bikegeek pushed a commit that referenced this issue Sep 26, 2024
* 461: scatter tests and json compare

* 461: tidy up docs and whitespace

* 461: remove accidental git add

* 461: hovmoeller test updates
@bikegeek bikegeek moved this from 🏗 In progress to 🔎 In review in METplus-Analysis-6.0.0 Development Oct 16, 2024
@bikegeek bikegeek moved this from 🔎 In review to 🏁 Done in METplus-Analysis-6.0.0 Development Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: testing Software testing issue METplotpy: General type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
2 participants