Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #461 move to pyproject.toml #462

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

John-Sharples
Copy link

@John-Sharples John-Sharples commented Sep 18, 2024

  • Remove existing setup.py and replace with pyproject.toml
  • move pytest and coverage config into pyproject.toml
  • update documentation
  • coverage report updated to ignore contributed plots

Note a change in behaviour: pip install . will now install ALL DEPENDANCIES as well as METplotpy. See docs for ways to avoid this.

Pull Request Testing

  • Describe testing already performed for these changes:

    tested local builds

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Confirm docs make sense and result in correct installation.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    NA

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    No

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@John-Sharples John-Sharples added this to the METplotpy-3.0.0 milestone Sep 18, 2024
@John-Sharples John-Sharples linked an issue Sep 18, 2024 that may be closed by this pull request
25 tasks
@John-Sharples John-Sharples changed the title Feature 461 move to pyproject.toml Feature #461 move to pyproject.toml Sep 18, 2024
@John-Sharples John-Sharples marked this pull request as ready for review September 18, 2024 20:57
@bikegeek bikegeek merged commit 4aa40b1 into develop Sep 18, 2024
8 checks passed
@bikegeek bikegeek deleted the feature_461-move-to-pyproject.toml branch September 18, 2024 20:58
@georgemccabe
Copy link
Contributor

We have technically deprecated the use of the email address [email protected] in favor of having users create new GitHub Discussion topics. @JohnHalleyGotway, is there another email address that can be used here? If not, perhaps we should create a Google Group that includes METplus support team members that can be included in python package info.

@bikegeek
Copy link
Collaborator

bikegeek commented Sep 18, 2024 via email

@John-Sharples
Copy link
Author

We can just remove the email from pyproject.toml. I don't think it's required... I just copied from the existing setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Improve unit test infrastructure and coverage
3 participants