Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 335 seeps column names #340

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Oct 10, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    on host 'mohawk', which has a (mySQL database instance):

Testing
working in BASH:

  1. using the conda environment: /d2/personal/mwin/mambaforge/envs/mp_analysis_env
  2. cloned METdataio and checked out the feature_335_SEEPS_column_names branch
  3. export PYTHONPATH=/d2/personal/mwin/feature_335_SEEPS/METdataio:/d2/personal/mwin/feature_335_SEEPS/METdataio/METdbLoad:/d2/personal/mwin/feature_335_SEEPS/METdataio/METdbLoad/ush
  4. create the database with appropriate privileges and load with point_stat MPR, ORANK, and SEEPS data from the MET nightly regression output (using copy and paste output from the db_cmd.bash script)
  5. added a test to the existing test_schema.py under the METdataio/METdbLoad/tests/update_schema_6.0_beta6 directory
  6. edited the test_loading.yaml to use mvadmin user and mvadmin's password and a new database name
  7. updated the db_load_specification.xml file to include the SEEPS data (use mvadmin and mvadmin's password)
  8. Ran the test: pytest test_schema.py
  9. verified all tests pass

Visually verified the following:
in METdataio/METdbLoad/updates/update_for_6_0_beta6.sql (the update instructions for users with existing databases):

  1. column s12 is renamed to odfl (RENAME COLUMN s12 TO odfl)
  2. column s13 is renamed to odfh (RENAME COLUMN s13 TO odfh)
  3. column s21 is renamed to olfd (RENAME COLUMN s21 TO olfd)
  4. column s23 is renamed to olfh (RENAME COLUMN s23 TO olfh)
  5. column s31 is renamed to ohfd (RENAME COLUMN s31 TO ohfd)
  6. column s32 is renamed to ohfl (RENAME COLUMN s32 TO ohfl)
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

From the issue, the following column names are affected:

S12 -> ODFL for the observation dry, forecast light category,
S13 -> ODFH for the observation dry, forecast heavy category,
S21 -> OLFD for the observation light, forecast dry category,
S23 -> OLFH for the observation light, forecast heavy category,
S31 -> OHFD for the observation heavy, forecast dry category,
S32 -> OHFL for the observation heavy, forecast light category

Verify that the METdataio/METdbLoad/updates/update_for_6_0_beta6.sql has correctly renamed the column names (except in lower case)

Verify that all Github Actions are passing

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [ No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Monday October 14].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek marked this pull request as draft October 10, 2024 23:58
@bikegeek bikegeek requested a review from j-opatz October 11, 2024 00:16
@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Oct 11, 2024
@bikegeek bikegeek marked this pull request as ready for review October 11, 2024 00:22
Copy link

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column names have been updated correctly, and all checks look successful.

@bikegeek bikegeek merged commit 02f3a00 into develop Oct 11, 2024
13 checks passed
@bikegeek bikegeek deleted the feature_335_SEEPS_column_names branch October 11, 2024 21:33
@jprestop jprestop linked an issue Oct 16, 2024 that may be closed by this pull request
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Modify the column names for the existing SEEPS line type in the database schema
2 participants