Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the column names for the existing SEEPS line type in the database schema #335

Closed
9 of 22 tasks
JohnHalleyGotway opened this issue Sep 24, 2024 · 1 comment · Fixed by #340
Closed
9 of 22 tasks

Modify the column names for the existing SEEPS line type in the database schema #335

JohnHalleyGotway opened this issue Sep 24, 2024 · 1 comment · Fixed by #340
Assignees
@bikegeek @j-opatz
Labels
component: load Tasks related to the database loading METdataio: Load STAT Data priority: high High Priority requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METdataio-3.0.0

Comments

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Sep 24, 2024 •
edited by bikegeek
Loading

Describe the Enhancement

This issue is the downstream impact of dtcenter/MET#2882. For this MET issue, @mpm-meto and @RachelNorth are changing the names of the existing SEEPS columns to provide more clarity and make them more intuitive:
S12 -> ODFL for the observation dry, forecast light category,
S13 -> ODFH for the observation dry, forecast heavy category,
S21 -> OLFD for the observation light, forecast dry category,
S23 -> OLFH for the observation light, forecast heavy category,
S31 -> OHFD for the observation heavy, forecast dry category,
S32 -> OHFL for the observation heavy, forecast light category

Recommend making this change only after dtcenter/MET#2882 is complete and a corresponding PR merges these changes into the develop branch.

Note that @mpm-meto has indicated that backward-compatibility is NOT required. If changes for this this issue no longer support loading v11.1 SEEPS output into METdataio, that's OK. If backward compatibility is easily added, please do so. If it's not easy, don't worry about it.

@bikegeek please also consider whether changes are needed in other METplus Analysis Tools repositories.

Time Estimate

2-3 days @bikegeek please update

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed

Relevant Deadlines

While the MetOffice funding will be extended until March 2025, it would be ideal to include the SEEPS changes in the METplus 6.0.0 beta6 development release for the MetOffice to test and validate.

Funding Source

MetOffice: 2799991 (coordinate with @j-opatz)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METdataio-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METdataio-X.Y.Z version, select the METdataio-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METdataio-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: load Tasks related to the database loading priority: high High Priority requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METdataio: Load STAT Data labels Sep 24, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METdataio-3.0.0 milestone Sep 24, 2024
@bikegeek bikegeek moved this from 🟢 Ready to 🏗 In progress in METplus-Analysis-6.0.0 Development Oct 8, 2024
bikegeek added a commit that referenced this issue Oct 10, 2024
@bikegeek
Issue #335 update column names for SEEPS data updates
9092e6d
bikegeek added a commit that referenced this issue Oct 10, 2024
@bikegeek
Issue #335 changed names of SEEPS columns to reflect changes in MET
3fdee3d
bikegeek added a commit that referenced this issue Oct 10, 2024
@bikegeek
Issue #335 add test for the changed SEEPS columns
eae44bf
bikegeek added a commit that referenced this issue Oct 11, 2024
@bikegeek
Feature 335 seeps column names (#340)
02f3a00 
* Added latest SEEPS data to the point_stat directory

* Updated extension from .txt to .stat to METdbLoad will recognize the files

* Issue #335 update column names for SEEPS data updates

* Issue #335 changed names of SEEPS columns to reflect changes in MET

* Issue #335 add test for the changed SEEPS columns

* script that generates DB commands used to create and drop the database
@bikegeek bikegeek moved this from 🏗 In progress to 🏁 Done in METplus-Analysis-6.0.0 Development Oct 11, 2024
@jprestop jprestop linked a pull request Oct 16, 2024 that will close this issue
Feature 335 seeps column names #340
Merged
15 tasks
@jprestop
Copy link
Collaborator

Closed with PR #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

@j-opatz j-opatz

Labels
component: load Tasks related to the database loading METdataio: Load STAT Data priority: high High Priority requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METdataio-3.0.0
Development

Successfully merging a pull request may close this issue.

Feature 335 seeps column names dtcenter/METdataio
4 participants
@bikegeek @jprestop @JohnHalleyGotway @j-opatz