Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 321 mpr reformatter update #323

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Aug 29, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

  • on 'seneca' and local host, ran all tests, including new test for the MPR reformatter for climo columns

  • DeprecationWarnings on np.find_common_type in the pandas code. Will NOT ignore these as this is a reminder to update to numpy >1.25 (currently used version is numpy 1.24)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    verify that the pytests all pass in Github Actions

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [very likely]

    If yes, please describe:
    on-going findings for duplicate code

  • Please complete this pull request review by [by September 12].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Aug 29, 2024
@bikegeek bikegeek marked this pull request as draft August 29, 2024 22:05
@bikegeek bikegeek linked an issue Aug 29, 2024 that may be closed by this pull request
22 tasks
@bikegeek bikegeek requested a review from jprestop August 29, 2024 22:07
@bikegeek bikegeek marked this pull request as ready for review August 29, 2024 22:11
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that all of the pytests passed in Github Actions. I approve this PR.

@bikegeek bikegeek merged commit 59696a8 into develop Aug 29, 2024
15 checks passed
@bikegeek bikegeek deleted the feature_321_mpr_reformatter_update branch August 29, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Make updates to the MPR reformatting in METreformat
2 participants