Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make updates to the MPR reformatting in METreformat #321

Closed
22 tasks
bikegeek opened this issue Aug 16, 2024 · 1 comment · Fixed by #323
Closed
22 tasks

Make updates to the MPR reformatting in METreformat #321

bikegeek opened this issue Aug 16, 2024 · 1 comment · Fixed by #323
Assignees
@bikegeek
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone
METdataio-3.0.0

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Aug 16, 2024 •
edited
Loading

Replace italics below with details for this issue.

Describe the Task

Additional columns were added to MET, which impacts the METdbLoad code used by the METreformat code for the MPR linetype:
#320

When making changes, consider refactoring to avoid making changes when new columns are added.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METdataio-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METdataio-X.Y.Z version, select the METdataio-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METdataio-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Aug 16, 2024
@bikegeek bikegeek self-assigned this Aug 16, 2024
@bikegeek bikegeek mentioned this issue Aug 16, 2024
Closed
26 tasks
@JohnHalleyGotway
Copy link
Contributor

@bikegeek FYI, the dtcenter/MET#2924 issue was completed today and the final PR merged. You can find updated MPR and ORANK data tomorrow in the output from the MET nightly build run on seneca.

@JohnHalleyGotway JohnHalleyGotway added this to the METdataio-3.0.0 milestone Aug 21, 2024
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Issue #321 additional MPR climo columns accounted for. MPR reformatti…
b16a58a 
…ng code is now immune from any future column additions.
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Issue #321 config file used in testing new MPR climo columns
de1985b
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Issue #321 test for MPR climo column additions
9abf043
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Issue #321 sample data with renamed and additional MPR climo columns
2a4514d
@bikegeek bikegeek linked a pull request Aug 29, 2024 that will close this issue
Feature 321 mpr reformatter update #323
Merged
15 tasks
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Feature 321 mpr reformatter update (#323)
59696a8 
* Issue #321 additional MPR climo columns accounted for.  MPR reformatting code is now immune from any future column additions.

* Issue #321 config file used in testing new MPR climo columns

* Issue #321 test for MPR climo column additions

* Issue #321 sample data with renamed and additional MPR climo columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METdataio-3.0.0
Development

Successfully merging a pull request may close this issue.

Feature 321 mpr reformatter update dtcenter/METdataio
2 participants
@bikegeek @JohnHalleyGotway