-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2780 grib tables #3005
Conversation
… from units strings
…with updates from the 109 defined in the wgrib2 table.
…tring to avoid problems writing them to FCST_UNITS and OBS_UNITS output columns
…f wgrib2: hera:/home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables/ncep/gribtable.dat
…ng them more human-readable by replacing ** with ^ to indicate exponentiation. Also correct bad units for radiation flux in AF tables by listing them as W/m^2.
…h 'mcg' to represent micrograms. Also replace 'mm6' with 'mm^6' by double-checking against the GRIB1 docs.
…' for consistent usage across NCEP GRIB tables.
…paring against documentation at https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc
…e the use of parantheses in the denominator. For example, replace 'kg/(m*s)' with 'kg/m/s'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like many of the * have changed to /. I just wanted to double check that this was intentional...
169 254 46 -1 "vmfl" "VERT. INTEGRATED MOISTURE FLUX CONV." "kg/(m2*s)" | ||
170 254 46 -1 "vadv" "VERTICAL MOISTURE ADVECTION " "kg/(kg*s)" | ||
171 254 46 -1 "nhcm" "NEG. HUM. CORR. MOISTURE SOURCE" "kg/(kg*s)" | ||
169 254 46 -1 "vmfl" "VERT. INTEGRATED MOISTURE FLUX CONV." "kg/m^2/s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this supposed to change from * to /? Same for the next 2 lines...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CPKalb, yes, it was an intentional change... switching from a/(b*c)
to a/b/c
which is mathematically equivalent. I found a pretty wide variety of conventions in units strings across GRIB1 and GRIB2 table sources. And I made these changes to move toward more consistency.
But please advise if you'd prefer that those differences be retained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnHalleyGotway, I think the change is fine, I just wanted to be sure. Like you said, there are a variety of ways to express it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through as many of the changes as I could in an hour and didn't see anything amiss.
Expected Differences
This PR makes changes to GRIB1 and GRIB2 table files in MET. These changes include:
FCST_UNITS
andOBS_UNITS
STAT header columns, where embedded whitespace is not allowed.**
to^
to consistently indicate exponentiation (e.g. switch fromm**2
tom^2
).**
or^
for exponentiation (e.g. switch fromm2
tom^2
)./
(e.g. switch fromm s**-1
tom/s
).kg/(m^2*s)
tokg/m^2/s
).grib1_dwd_*.txt
tables) do still include embedded whitespace. MET does check for that when writing theFCST_VAR
andOBS_VAR
STAT header columns and reports this error message:Users can use
set_attr_name = "TMP"
to provide a non-whitespace version of the name.Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
None yet.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Spend no more than 1 hour scanning the differences, looking for obvious problems in changes to the tables, in particular for updated unit strings.
Please refer to this NCEP GRIB2 documentation and this NCEP GRIB1 documentation only when needed.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed.
Do these changes include sufficient testing updates? [Yes]
None needed.
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
The vorticity units reported to the MET differ:
See the GRIB2 table documentation for:
Will this PR result in changes to existing METplus Use Cases? [Probably]
If yes, create a new Update Truth METplus issue to describe them.
The units reported to the MET output may differ.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
I expect no impact.
Please complete this pull request review by [Tues 11/5/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases