Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GRIB2 tables in MET based on wgrib2 version 3.1.4 #2780

Open
8 of 21 tasks
JohnHalleyGotway opened this issue Jan 8, 2024 · 2 comments
Open
8 of 21 tasks

Update GRIB2 tables in MET based on wgrib2 version 3.1.4 #2780

JohnHalleyGotway opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Library Code priority: high High Priority requestor: NOAA/other NOAA Laboratory, not otherwise specified required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

This issue was discussed during the METplus NOAA User Telecon on Jan 8, 2024 (see meeting notes - limited access). Gwen indicated that wgrib2 version 3.1.4 is under development and will include updates to some of the GRIB2 tables.

NCEP GRIB2 tables have been updated with new WMO-approved variables (27 freezing/melting potential, 28 melt onset date, and 29 freeze onset date in Table 4.2-10-2 and Level 172 in Table 4.5).

A new release v3.1.4 will be installed on Acorn soon for testing. If successful, it will be delivered to WCOSS2.

This issue is to:

  • Download the v3.1.4 release when it becomes available.
  • Update the contents of the GRIB2 table files in data/table_files/grib2_*.txt as needed.

Recommend requesting that Gwen (Li-Chuan Chen) serve as the tester for these table updates.

Time Estimate

1 day.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: NOAA/other NOAA Laboratory, not otherwise specified alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Library Code priority: high High Priority labels Jan 8, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Jan 8, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jan 8, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

Note that discussion dtcenter/METplus#2465 points out that the FSNOWC variable from GRIB2 table 4.2-0-1 is also missing. Double-check to confirm that updates to this table are included in MET version 12.0.0.

@JohnHalleyGotway JohnHalleyGotway added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label May 13, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

At the METplus NOAA User Telecon on 5/13/24, @MarcelCaron-NOAA requested that grib2_mrms.txt be updated to include ~10 new lines for FRANA for this sample of the 24-hour flat ice product:

MRMS_EXP_FRANA_Flat_1440min_00.00_20240123-000000.grib2.gz

Test to confirm that the ice product data is read from these files well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Library Code priority: high High Priority requestor: NOAA/other NOAA Laboratory, not otherwise specified required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
Status: 🟢 Ready
Development

No branches or pull requests

1 participant