Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] add d3d9.enableDialogMode for CatSystem2 games already on Steam #4465

Closed
wants to merge 1 commit into from

Conversation

qinlili23333
Copy link
Contributor

@qinlili23333 qinlili23333 commented Nov 16, 2024

Like krkrz, CatSystem2 games also need GDI for top menu bar which cannot work well under exclusive FS.
May lack games not on Steam.
CatSystem2 games are not too much, so adding them to config is easier than detect it.

About 20 games, so the regex is a bit long but it works.
I'm not good at regex and I don't know how to make it in multiple lines. Maybe someone can help me to do it.

May lack games not on Steam.
CatSystem2 games are not too much, so adding them to config is easier than detect it.
@doitsujin
Copy link
Owner

I don't really want to do this. Together with the other thing we're talking like several hundred games that no one has really heard about here, I'd rather just disable FSE by default and have these work without littering the code base with this. Doing that will need some discussion + testing though.

@qinlili23333
Copy link
Contributor Author

I don't really want to do this. Together with the other thing we're talking like several hundred games that no one has really heard about here, I'd rather just disable FSE by default and have these work without littering the code base with this. Doing that will need some discussion + testing though.

I approve disabling FSE by default should solve the most compatibility issues. Although there may be some performance drop without FSE, d3d9 games usually won't reach GPU bottleneck for most modern GPUs.

@qinlili23333
Copy link
Contributor Author

Close as superseded by #4485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants