Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Disable exclusive fullscreen for KiriKiri Z games #4464

Closed
wants to merge 2 commits into from

Conversation

qinlili23333
Copy link
Contributor

@qinlili23333 qinlili23333 commented Nov 16, 2024

KiriKiri Z games rely on GDI for top menu bar. If exclusive FS enabled, display or hide menu will result black flicker. So we disable exclusive FS for KiriKiri Z games. Tested on 9-nine- series and Corona Blossom series on Windows 11 and Kali latest with Nvidia GPU.

Edit: Some other galgames also have similar behavior to krkrz, maybe we also need to add them into this new function.
I didn't add krkr2 because krkr2 relies on gdi heavily and only use d3d9 for limited features lick video playback which is nearly impossible to handle well in dxvk.

Edit2: CatSystem2 games have the same behavior, but I have difficulty to detect it. (example: Nekopara Vol.3, Love's Sweet Garnish)

KiriKiri Z games rely on GDI for top menu bar. If exclusive FS enabled, display or hide menu will result black flicker. So we disable exclusive FS for KiriKiri Z games. Tested on 9-nine- series and Corona Blossom series on Windows 11 and Kali latest with Nvidia GPU.
@WinterSnowfall
Copy link
Contributor

Just how many KiriKiri Z games are there and why can't we simply use executable-name based config overrides, which is like what we almost universally do for everything else?

@qinlili23333
Copy link
Contributor Author

qinlili23333 commented Nov 16, 2024

Just how many KiriKiri Z games are there and why can't we simply use executable-name based config overrides, which is like what we almost universally do for everything else?

Approx 100-200 titles on Steam, while a large amount of titles are not released on Steam. It will be a difficult work to collect file names for all these titles.
Also, galgames usually have a lot of fan made translated version with different file name, which makes it more difficult to write rules for all of them.

That't why I prefer to use universal fix for krkrz games just like what we do for UE4 games.

While for CatSystem2 games (only approx less than 30 titles and have no explicit dll handle to detect), I approve that rules can be better. I have made another branch for configs of these games #4465 .

@qinlili23333
Copy link
Contributor Author

Close as superseded by #4485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants