Add shapecast example + loosen gjk epsilon #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
changed the title
Vrixyz
commented
Dec 27, 2024
Comment on lines
36
to
39
| pub fn eps_tol() -> Real { | ||
| let _eps = crate::math::DEFAULT_EPSILON; | ||
| _eps * 10.0 | ||
| _eps * 10_000.0 | ||
| } |
There was a problem hiding this comment.
I'm not a huge fan of increasing epsilons arbitrarily, but that improves the example added in this PR.
I think exposing this value would be more interesting, and I'd like to have a test stressing false positive, where a high epsilon results in an incorrect result 🤔 (or performance overhead, I'm not sure)
Vrixyz
commented
Dec 27, 2024
Comment on lines
+22
to
+28
| [ | ||
| [600.0, 288.0].into(), | ||
| [576.0, 312.0].into(), | ||
| [552.0, 288.0].into(), | ||
| [576.0, 264.0].into(), | ||
| ] | ||
| .into(), |
There was a problem hiding this comment.
check if that works on a centered shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on discord, a shape cast of a ball sometimes fails when it should not.
time_of_impact_support_map_support_mapreturnsNonewhen it shouldn't with very specific inputs #180Before this PR:
After this PR: