Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce the max instructions of heartbeats from 4B to 2B #293

Merged
merged 1 commit into from
Apr 17, 2024
Merged

chore: reduce the max instructions of heartbeats from 4B to 2B #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions canister/src/heartbeat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ mod test {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 3 inputs/outputs per round.
runtime::set_performance_counter_step(1_000_000_000);
runtime::set_performance_counter_step(500_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down Expand Up @@ -508,7 +508,7 @@ mod test {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 3 transactions inputs/outputs per round.
runtime::set_performance_counter_step(1_000_000_000);
runtime::set_performance_counter_step(500_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down
2 changes: 1 addition & 1 deletion canister/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ async fn time_slices_large_block_with_multiple_transactions() {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 2 transactions inputs/outputs per round.
runtime::set_performance_counter_step(1_500_000_000);
runtime::set_performance_counter_step(750_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down
5 changes: 3 additions & 2 deletions canister/src/utxo_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,8 +555,9 @@ impl PartialEq for UtxoSet {
// Checks that we're not approaching the instructions limit.
fn default_should_time_slice() -> Box<dyn FnMut() -> bool> {
// The threshold at which time slicing kicks in.
// At the time of this writing it is equivalent to 80% of the maximum instructions limit.
const MAX_INSTRUCTIONS_THRESHOLD: u64 = 4_000_000_000;
// At the time of this writing it is equivalent to 40% of the maximum instructions limit.
// NOTE: We've reduced this limit from 4B to 2B in an effort to keep the FR stable.
const MAX_INSTRUCTIONS_THRESHOLD: u64 = 2_000_000_000;

// NOTE: We're using `inc_performance_counter` here to also increment the mock performance
// counter in the unit tests.
Expand Down
Loading