Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce the max instructions of heartbeats from 4B to 2B #293

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Apr 17, 2024

In an effort to make the FR of the Bitcoin subnet more stable, we reduce the amount of instructions we aim to execute in a single heartbeat execution from 4B instructions to 2B instructions. The hypothesis is that this will lead to a higher and more stable FR overall.

@ielashi ielashi requested a review from a team as a code owner April 17, 2024 13:11
@ielashi ielashi enabled auto-merge (squash) April 17, 2024 13:19
Copy link

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (-0.00%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (-0.00%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@ielashi ielashi merged commit 3a0d299 into master Apr 17, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/instructions_limit branch April 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants