Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: Remove addonmanager label from node-local-dns configmap and make annotations configurable #639

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[stable/node-local-dns]: Remove addonmanager label from node-local-dns configmap and make annotations configurable #639

merged 4 commits into from
Dec 12, 2024

Conversation

jem41
Copy link
Contributor

@jem41 jem41 commented Dec 11, 2024

Description

  • Remove hardcoded addonmanager.kubernetes.io label from node-local-dns as it is unnecessary when installing with Helm.
  • Add option to configure additional labels to node-local-dns configmap
  • Add option to configure annotations to node-local-dns configmap

Closes #623

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@jem41 jem41 requested a review from a team as a code owner December 11, 2024 15:47
max-rocket-internet
max-rocket-internet approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, like it, thanks @jem41 💚

@jem41
Copy link
Contributor Author

jem41 commented Dec 11, 2024 •
edited
Loading

I forgot to regenerate the docs after 71ba839, making the labels configurable as well. It should be good to go now. Fixed in 962d69e

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) December 12, 2024 08:35
@max-rocket-internet max-rocket-internet merged commit ecacadf into deliveryhero:master Dec 12, 2024
7 checks passed
@jem41 jem41 deleted the Remove-addonmanager-label-and-make-annotations-configurable-for-configmap branch December 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet Awaiting requested review from max-rocket-internet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-local-dns ConfigMap deletion
2 participants
@jem41 @max-rocket-internet