Skip to content

Commit

Permalink
[stable/node-local-dns]: Remove addonmanager label from node-local-dn…
Browse files Browse the repository at this point in the history
…s configmap and make annotations configurable (#639)

* Remove addonmanager label from node-local-dns configmap and make annotations configurable

* Make labels configurable too

* Re-update docs after making labels configurable

* Fix readme
  • Loading branch information
jem41 authored Dec 12, 2024
1 parent 826a44f commit ecacadf
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion stable/node-local-dns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: node-local-dns
version: 2.1.1
version: 2.1.2
appVersion: 1.23.1
maintainers:
- name: gabrieladt
Expand Down
6 changes: 4 additions & 2 deletions stable/node-local-dns/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-local-dns

![Version: 2.1.1](https://img.shields.io/badge/Version-2.1.1-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)
![Version: 2.1.2](https://img.shields.io/badge/Version-2.1.2-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)

A chart to install node-local-dns.

Expand All @@ -23,7 +23,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-d
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.1
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.2
```

To install the chart with the release name `my-release`:
Expand Down Expand Up @@ -63,6 +63,8 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/node-local-dns -f
| config.setupInterface | bool | `true` | |
| config.setupIptables | bool | `true` | |
| config.skipTeardown | bool | `false` | |
| configMapAnnotations | object | `{}` | |
| configMapLabels | object | `{}` | |
| daemonsetAnnotations | object | `{}` | |
| daemonsetLabels | object | `{}` | |
| dashboard | object | `{"annotations":{},"enabled":false,"label":"grafana_dashboard","namespace":"kube-system"}` | https://github.com/grafana/helm-charts/blob/main/charts/grafana/README.md |
Expand Down
8 changes: 7 additions & 1 deletion stable/node-local-dns/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,15 @@ kind: ConfigMap
metadata:
name: {{ include "node-local-dns.fullname" . }}
namespace: kube-system
{{- with .Values.configMapAnnotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
labels:
addonmanager.kubernetes.io/mode: Reconcile
{{- include "node-local-dns.labels" . | nindent 4 }}
{{- with .Values.configMapLabels }}
{{- toYaml . | nindent 4 }}
{{- end }}
data:
Corefile: |
{{- if .Values.config.customConfig -}}
Expand Down
4 changes: 4 additions & 0 deletions stable/node-local-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ podAnnotations: {}

podLabels: {}

configMapAnnotations: {}

configMapLabels: {}

daemonsetAnnotations: {}

daemonsetLabels: {}
Expand Down

0 comments on commit ecacadf

Please sign in to comment.