-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug finding implicit namespace packages #1784
Open
bbugyi200
wants to merge
24
commits into
davidhalter:master
Choose a base branch
from
bbugyi200:1759-fix-implicit-namespace-packages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
59f1253
Fix bug finding implicit namespace packages
bbugyi200 d17c1a1
Add type hints to _find_module() function
bbugyi200 f979b2a
Add type signatures to get_module_info() function
bbugyi200 39b8e07
Add type annotations to import_module*() functions
bbugyi200 915bc00
Add inline comment
bbugyi200 cf0ae8b
Improve return type annotations
bbugyi200 48bcaa8
Add tests for bugfix
bbugyi200 0396e72
Revert 'sorted' back to 'set'
bbugyi200 120be69
Fix tests that were broken by adding new example directories
bbugyi200 ca4ebe2
Fix unrelated test_find_module_not_package_zipped() test
bbugyi200 53980af
Remove unused function
bbugyi200 708eb3b
Remove type signature from import_module_by_names()
bbugyi200 6d8b66e
Change type on sys_path to Sequence[str]
bbugyi200 6aad95a
Add bullet to changelog
bbugyi200 fe0e9f6
Add my name to AUTHORS.txt
bbugyi200 3fa026a
Reverse PR/issue links in changelog bullet
bbugyi200 a51f1e8
Simplify main fix in _find_module() function
bbugyi200 ead07aa
Simplify changes to _find_module() further
bbugyi200 68161e5
Last simplification
bbugyi200 44706a3
Remove unused imports
bbugyi200 149148c
Change name from 'path' to 'paths'
bbugyi200 daecd8b
Rename 'paths' back to 'path' since that's what importlib uses
bbugyi200 33d5a6e
Add type annotations to two more functions in _functions.py
bbugyi200 06bac01
Rename last 'paths' to 'path'
bbugyi200 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,7 @@ Code Contributors | |
- Andrii Kolomoiets (@muffinmad) | ||
- Leo Ryu (@Leo-Ryu) | ||
- Joseph Birkner (@josephbirkner) | ||
- Bryan Bugyi (@bbugyi200) <[email protected]> | ||
|
||
And a few more "anonymous" contributors. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Any hints, they are pretty much useless (and also wrong).