Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug finding implicit namespace packages #1784

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Fix bug finding implicit namespace packages #1784

wants to merge 24 commits into from

Commits on Jul 2, 2021

  1. Fix bug finding implicit namespace packages

    @bbugyi200
    bbugyi200 committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    59f1253 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. Add type hints to _find_module() function

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    d17c1a1 View commit details
    Browse the repository at this point in the history

  2. Add type signatures to get_module_info() function

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    f979b2a View commit details
    Browse the repository at this point in the history

  3. Add type annotations to import_module*() functions

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    39b8e07 View commit details
    Browse the repository at this point in the history

  4. Add inline comment

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    915bc00 View commit details
    Browse the repository at this point in the history

  5. Improve return type annotations

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    cf0ae8b View commit details
    Browse the repository at this point in the history

  6. Add tests for bugfix

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    48bcaa8 View commit details
    Browse the repository at this point in the history

  7. Revert 'sorted' back to 'set'

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    0396e72 View commit details
    Browse the repository at this point in the history

  8. Fix tests that were broken by adding new example directories

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    120be69 View commit details
    Browse the repository at this point in the history

  9. Fix unrelated test_find_module_not_package_zipped() test 

    Not sure how this is passing in CI but failing locally.
    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    ca4ebe2 View commit details
    Browse the repository at this point in the history

  10. Remove unused function

    @bbugyi200
    bbugyi200 committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    53980af View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. Remove type signature from import_module_by_names() 

    ...since I never touched this function for anything else.
    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    708eb3b View commit details
    Browse the repository at this point in the history

  2. Change type on sys_path to Sequence[str]

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    6d8b66e View commit details
    Browse the repository at this point in the history

  3. Add bullet to changelog

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    6aad95a View commit details
    Browse the repository at this point in the history

  4. Add my name to AUTHORS.txt

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    fe0e9f6 View commit details
    Browse the repository at this point in the history

  5. Reverse PR/issue links in changelog bullet

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    3fa026a View commit details
    Browse the repository at this point in the history

  6. Simplify main fix in _find_module() function

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    a51f1e8 View commit details
    Browse the repository at this point in the history

  7. Simplify changes to _find_module() further

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    ead07aa View commit details
    Browse the repository at this point in the history

  8. Last simplification

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    68161e5 View commit details
    Browse the repository at this point in the history

  9. Remove unused imports

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    44706a3 View commit details
    Browse the repository at this point in the history

  10. Change name from 'path' to 'paths'

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    149148c View commit details
    Browse the repository at this point in the history

  11. Rename 'paths' back to 'path' since that's what importlib uses

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    daecd8b View commit details
    Browse the repository at this point in the history

  12. Add type annotations to two more functions in _functions.py

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    33d5a6e View commit details
    Browse the repository at this point in the history

  13. Rename last 'paths' to 'path'

    @bbugyi200
    bbugyi200 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    06bac01 View commit details
    Browse the repository at this point in the history