Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart_flutter_team_lints] add strict_top_level_inference #328

Merged
merged 4 commits into from
Dec 20, 2024
Merged

[dart_flutter_team_lints] add strict_top_level_inference #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e765f90
[dart_flutter_team_lints] add strict_top_level_inference
devoncarew Dec 16, 2024
894a46c
Update CHANGELOG.md
devoncarew Dec 19, 2024
cff9425
switch to dev for the publishing workflow
devoncarew Dec 19, 2024
e242ef9
switch to dev for the health workflow
devoncarew Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dart_flutter_team_lints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [stable, dev]
sdk: [dev] # TODO: add back in stable
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/health_internal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
# A CI configuration to check PR health.

name: Health:Internal

on:
pull_request:
branches: [ main ]
types: [opened, synchronize, reopened, labeled, unlabeled]

jobs:
health:
uses: ./.github/workflows/health.yaml
with:
sdk: dev
local_debug: true
coverage_web: false
upload_coverage: false
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_internal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,19 @@
# publishing code at head.

name: Publish:Internal

on:
pull_request:
branches: [ main ]
types: [opened, synchronize, reopened, labeled, unlabeled]
push:
tags: [ '[A-z]+-v[0-9]+.[0-9]+.[0-9]+*' ]

jobs:
publish:
uses: ./.github/workflows/publish.yaml
with:
local_debug: true
use-flutter: false
write-comments: false
sdk: dev
5 changes: 5 additions & 0 deletions pkgs/dart_flutter_team_lints/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 3.3.0

- Added `strict_top_level_inference`.
- Require Dart `3.7`.

## 3.2.1

- Depend on the `5.0.0` release of `package:lints`.
Expand Down
1 change: 1 addition & 0 deletions pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ linter:
- comment_references
- conditional_uri_does_not_exist
- only_throw_errors
- strict_top_level_inference
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
Expand Down
4 changes: 2 additions & 2 deletions pkgs/dart_flutter_team_lints/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
version: 3.2.1
version: 3.3.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints

environment:
sdk: ^3.5.0
sdk: ^3.7.0-0

dependencies:
lints: ^5.0.0
Expand Down
Loading