Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart_flutter_team_lints] add strict_top_level_inference #328

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Dec 16, 2024

  • add the new strict_top_level_inference lint
  • update the sdk dependency
  • rev for publishing

Note that this won't build cleanly until a dev sdk is released that contains strict_top_level_inference; I'll hold off on landing / publishing this until then.

w/ the pubspec constraints here:

  • most packages using this (^3.0.0) will solve for this new version of the package
  • they'll only get this version if they happen to be running pub get on a 3.7 dev version of the sdk
  • many repos in dart-lang will pick up this version, but only from the build jobs running on a dev sdk

I think we can publish this and fix up the failing jobs reactively.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:dart_flutter_team_lints type-infra A repository infrastructure change or enhancement labels Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.2.1 3.3.0 3.2.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.3.0 ready to publish dart_flutter_team_lints-v3.3.0
package:firehose 0.10.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@devoncarew devoncarew merged commit d42c4d2 into main Dec 20, 2024
13 checks passed
@devoncarew devoncarew deleted the rev_dart_flutter_team_lints branch December 20, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dart_flutter_team_lints publish-ignore-warnings type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants