Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define the minimum supported Python version as 3.6 #7007

Merged
merged 1 commit into from
Nov 15, 2024
Merged

define the minimum supported Python version as 3.6 #7007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/scriptcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions:
jobs:
build:

# 'ubuntu-22.04' removes Python 3.5 and 3.6 so keep the previous LTS version
# 'ubuntu-22.04' removes Python 3.6 so keep the previous LTS version
runs-on: ubuntu-20.04

steps:
Expand All @@ -44,7 +44,7 @@ jobs:
scriptcheck:

needs: build
# 'ubuntu-22.04' removes Python 3.5 and 3.6 so keep the previous LTS version
# 'ubuntu-22.04' removes Python 3.6 so keep the previous LTS version
runs-on: ubuntu-20.04
strategy:
matrix:
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
if: matrix.python-latest
run: |
shopt -s globstar
pylint --jobs $(nproc) addons/**/*.py htmlreport/cppcheck-htmlreport htmlreport/**/*.py test/**/*.py tools/**/*.py
pylint --jobs $(nproc) --py-version 3.6 addons/**/*.py htmlreport/cppcheck-htmlreport htmlreport/**/*.py test/**/*.py tools/**/*.py

- name: check .json files
if: matrix.python-latest
Expand Down
12 changes: 9 additions & 3 deletions cmake/findDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,15 @@ else()
endif()
endif()

if(NOT Python_Interpreter_FOUND AND NOT USE_MATCHCOMPILER_OPT STREQUAL "Off")
message(WARNING "No python interpreter found - disabling matchcompiler.")
set(USE_MATCHCOMPILER_OPT "Off")
if(NOT Python_Interpreter_FOUND)
if(NOT USE_MATCHCOMPILER_OPT STREQUAL "Off")
message(WARNING "No python interpreter found - disabling matchcompiler.")
set(USE_MATCHCOMPILER_OPT "Off")
endif()
else()
if(${Python_VERSION} VERSION_LESS 3.6)
message(FATAL_ERROR "The minimum supported Python version is 3.6 - found ${Python_VERSION}")
endif()
endif()

if(NOT USE_BUNDLED_TINYXML2)
Expand Down
2 changes: 2 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ There are multiple compilation choices:
* GCC (g++)
* Clang (clang++)

The minimum required Python version is 3.6.

### CMake

The minimum required version is CMake 3.5.
Expand Down
4 changes: 2 additions & 2 deletions tools/donate-cpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,10 @@
print('Unhandled argument: ' + arg)
sys.exit(1)

if sys.version_info.major < 3 or (sys.version_info.major == 3 and sys.version_info.minor < 4):
if sys.version_info.major < 3 or (sys.version_info.major == 3 and sys.version_info.minor < 6):
print("#" * 80)
print("IMPORTANT")
print("Please run the client with at least Python 3.4, thanks!")
print("Please run the client with at least Python 3.6, thanks!")
print("#" * 80)
time.sleep(2)
sys.exit(1)
Expand Down
Loading