changed most Settings pointers to references
#6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #6297 to be merged first. |
|
It is quite disconcerting that none of the tests had to be adjusted... |
firewave
added
the
merge-after-next-release
|
I think we should wait for the next release before we apply this so we leverage the daca diffs to see if this has some kind of feedback. |
firewave
changed the title
Settings pointers to references
|
So I went all out and changed almost all |
firewave
force-pushed
the
ptr-ref-55xx-x
branch
from
e504b90
to
93b18bd
Compare
👍 |
firewave
removed
the
merge-after-next-release
|
Would be good to merge this still early in the dev cycle so the fallout might be easier to differentiate from other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.