Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid some (unnecessary) default parameters in GUI class constructors / added TODOs #6297

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I did not blindly add the parameters as it would change the behavior. This needs to be evaluated for each case if this was intentional or not.

@chrchr-github
Copy link
Collaborator

I think we should always pass settings if available, since that should only improve the results.

@firewave
Copy link
Collaborator Author

I think we should always pass settings if available, since that should only improve the results.

Alright. Will do.

I was thinking about setting breakpoints to the lines where no options are being passed to be able to extract some test cases. But that can still be done.

@firewave
Copy link
Collaborator Author

It turns out this has quite a ripple effect so we should probably do that in a separate PR.

@firewave
Copy link
Collaborator Author

It turns out this has quite a ripple effect so we should probably do that in a separate PR.

See #6298.

@chrchr-github
Copy link
Collaborator

https://doc.qt.io/qt-6/qwidget.html#QWidget
So there should be a noticeable difference in window behavior when passing a parent. Are those classes ever used as child windows?

@firewave firewave marked this pull request as draft April 16, 2024 13:20
@firewave
Copy link
Collaborator Author

I will re-structure these PRs.

@firewave firewave changed the title avoid some (unnecessary) default parameters / added TODOs avoid some (unnecessary) default parameters in GUI class constructors / added TODOs Apr 17, 2024
@danmar
Copy link
Owner

danmar commented Apr 18, 2024

So there should be a noticeable difference in window behavior when passing a parent. Are those classes ever used as child windows?

Spontanously I don't think so. We either always use the Qt classes with parent in a window. Or always as a window without parent. I vote to remove the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants