fixed #12526 - corrected bailout in valueFlowConditionExpressions() / restored valueFlowBailoutIncompleteVar in daca
#6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to add a test. |
firewave
changed the title
valueFlowConditionExpressions()valueFlowConditionExpressions()
firewave
force-pushed
the
vf-f-bailour
branch
5 times, most recently
from
9e4edce
to
ddb0726
Compare
firewave
changed the title
valueFlowConditionExpressions()valueFlowConditionExpressions() / restored valueFlowBailoutIncompleteVar in daca
firewave
commented
Mar 19, 2024
| @@ -302,6 +302,7 @@ void g_new0_test() | |||
| int b; | |||
| }; | |||
| // valid | |||
| // cppcheck-suppress valueFlowBailoutIncompleteVar | |||
There was a problem hiding this comment.
This looks like a false positive. Will file a ticket if necessary after this has been merged,
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bailout was moved out of an inner loop in a3617fe but it kept the previous
break. This caused it to bail out completely instead of just skipping the function.References for the added defines:
https://learn.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-createeventexa#parameters
https://learn.microsoft.com/en-us/windows/win32/secauthz/well-known-sids