made all suppressions in cfg tests inline / added TODOs
#6154
Conversation
|
I broke this in #5840 by not thinking about the implications of globally suppressing I will look into the TODOs and file tickets later. |
firewave
changed the title
cfg tests inline / added TODOs [skip ci]cfg tests inline / added TODOs
test/cfg/qt.cpp
Outdated
| QRegion a; | ||
| // cppcheck-suppress unreadVariable | ||
| // TODO cppcheck-suppress unreadVariable |
There was a problem hiding this comment.
These are most likely https://trac.cppcheck.net/ticket/12366.
test/cfg/qt.cpp
Outdated
| @@ -35,9 +37,9 @@ | |||
|
|
|||
| void unreadVariable_QRegion(const int x, const QRegion::RegionType type, const QPolygon &polygon, const QBitmap &bm, const QRegion ®ion, const Qt::FillRule fillRule) | |||
| { | |||
| // cppcheck-suppress unreadVariable | |||
| // TODO cppcheck-suppress unreadVariable | |||
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/12529 about these.
test/cfg/qt.cpp
Outdated
| @@ -576,7 +578,6 @@ void validCode(int * pIntPtr, QString & qstrArg, double d) | |||
|
|
|||
| printf(QT_TR_NOOP("Hi")); | |||
|
|
|||
| // cppcheck-suppress checkLibraryFunction | |||
There was a problem hiding this comment.
This was fixed by #5960.
| @@ -2469,21 +2471,21 @@ void uninitvar_ldexp(void) | |||
| void invalidFunctionArg_lgamma(float f, double d, long double ld) | |||
| { | |||
| (void)lgamma(d); | |||
| // cppcheck-suppress invalidFunctionArg | |||
| // TODO cppcheck-suppress invalidFunctionArg | |||
There was a problem hiding this comment.
This was added in #5845 and was never detected. @orbitcowboy
There was a problem hiding this comment.
Looks like !0.0: doesn't work, e.g. log() has <valid>4.94066e-324:</valid>.
test/cfg/std.cpp
Outdated
| @@ -4963,7 +4965,7 @@ void memleak_std_realloc(void* block, size_t newsize) | |||
|
|
|||
| void unusedAllocatedMemory_std_free() | |||
| { | |||
| //cppcheck-suppress unusedAllocatedMemory | |||
| //TODO cppcheck-suppress unusedAllocatedMemory | |||
There was a problem hiding this comment.
This was added in #5861 but was never detected. @chrchr-github
|
I have no idea what is going on with |
I still do not get what is going on there. I think we should merge this ASAP so we do not regress any further and look into it afterwards. I also want to get #6153 merged first. |
firewave
force-pushed
the
cfg-bailout
branch
2 times, most recently
from
c7af6a2
to
236073c
Compare
unmatchedSuppressionwas suppressed globally which obviously has the effect that we got no feedback when an expected warning was not being reported.