-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12420: SymbolDatabase: function in blockscope #5960
Conversation
We are not checking yet if it's valid code. Just a first take |
I think a TestSymbolDatabase test case would be useful to show that it works as intended. And then it would be interesting if you could run the test-my-pr.py script for a while and see what happens.. |
my_check_diff.log |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Yes.. I tested this code:
|
I discussed that to introduce this more carefully.. but yes you are right.. |
This has caused a crash: https://trac.cppcheck.net/ticket/12432 |
Fixed with #5978 |
No description provided.