New check: eraseIteratorOutOfBounds

lib/astutils.cpp

@@ -3019,8 +3019,10 @@ const Token* findExpressionChangedSkipDeadCode(const Token* expr,
 const Token* getArgumentStart(const Token* ftok)
 {
     const Token* tok = ftok;
-    if (Token::Match(tok, "%name% (|{"))
+    if (Token::Match(tok, "%name% (|{|)"))
         tok = ftok->next();
+    while (Token::simpleMatch(tok, ")"))
+        tok = tok->next();
     if (!Token::Match(tok, "(|{|["))
         return nullptr;
     const Token* startTok = tok->astOperand2();

lib/checkstl.cpp

@@ -3152,14 +3152,13 @@ void CheckStl::eraseIteratorOutOfBounds()
             if (!tok->valueType())
                 continue;
             const Library::Container* container = tok->valueType()->container;
-            if (!container)
-                continue;
-            if (!Token::Match(tok->next(), ". %name% ("))
+            if (!container || !Token::simpleMatch(tok->astParent(), "."))
                 continue;
-            const Library::Container::Action action = container->getAction(tok->strAt(2));
+            const Token* const ftok = tok->astParent()->astOperand2();
+            const Library::Container::Action action = container->getAction(ftok->str());
             if (action != Library::Container::Action::ERASE)
                 continue;
-            const std::vector<const Token*> args = getArguments(tok->tokAt(2));
+            const std::vector<const Token*> args = getArguments(ftok);
             if (args.size() != 1) // empty range is ok
                 continue;
 
@@ -3176,7 +3175,7 @@ void CheckStl::eraseIteratorOutOfBounds()
                         errVal = startVal;
             }
             if (errVal)
-                eraseIteratorOutOfBoundsError(tok->tokAt(2), args[0], errVal);
+                eraseIteratorOutOfBoundsError(ftok, args[0], errVal);
         }
     }
 }

test/teststl.cpp

@@ -2192,6 +2192,13 @@ class TestStl : public TestFixture {
               "}\n");
         ASSERT_EQUALS("[test.cpp:3]: (warning) Either the condition 'it==v.end()' is redundant or function 'erase()' is called on the iterator 'it' which is out of bounds.\n",
                       errout.str());
+
+        check("void f() {\n"
+              "    std::vector<int> v;\n"
+              "    ((v).erase)(v.begin());\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:3]: (error) Calling function 'erase()' on the iterator 'v.begin()' which is out of bounds.\n",
+                      errout.str());
     }
 
     // Dereferencing invalid pointer