New check: eraseIteratorOutOfBounds

[chrchr-github]

No description provided.

[chrchr-github]

Why would we set the ITERATOR_END value for end() - 1? Or is it meant to be interpreted together with the intvalue?

[pfultz2]

Why would we set the ITERATOR_END value for end() - 1?

The ITERATOR_END is the position from the end. So end() - 1 should have intvalue of -1. We can also check if the end iterator is out of range if its less than -size().

[danmar]

lgtm