run more tests in sanitizer workflows #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
|
These currently fail because of https://trac.cppcheck.net/ticket/12108. They are also necessary to have a working test for #5589. |
firewave
changed the title
|
Also needs improvements that we actually see the sanitizer output in the pytest results. |
firewave
force-pushed
the
pytest-lookup
branch
from
8ba42a1
to
8bd120b
Compare
|
This should run successfully after merging #5746. |
firewave
force-pushed
the
pytest-lookup
branch
4 times, most recently
from
45479a2
to
9364017
Compare
firewave
force-pushed
the
pytest-lookup
branch
from
9364017
to
1c84904
Compare
…LOOKUP_PATH` to specify custom lookup path
firewave
force-pushed
the
pytest-lookup
branch
from
1c84904
to
35bd295
Compare
I think changing the order in which we check the process results should be enough for that. The sanitizers log to stderr so we should check that first. Will do some tests in do the batch change in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.