Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12111 - memory leak with -j2 and --cppcheck-build-dir #5589

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Still needs a unit test.

@firewave
Copy link
Collaborator Author

We could change the result of those functions to std::unique_ptr to make it more explicit.

@firewave
Copy link
Collaborator Author

Requires #5744 to be merged first so the tests are run with AddressSanitizer (which includes LeakSanitizer) so the potential leaks are detected.

@firewave firewave marked this pull request as ready for review December 16, 2023 20:05
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but lets wait until it can be detected with the leak sanitizer

@firewave
Copy link
Collaborator Author

lgtm but lets wait until it can be detected with the leak sanitizer

That was already merged in #5744. LSAN is part of ASAN.

@firewave firewave merged commit 086ceea into danmar:main Dec 17, 2023
68 checks passed
@firewave firewave deleted the fi-memleak branch January 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants