use more granular suppressions in selfcheck and prefer inline suppressions

[firewave]

No description provided.

[firewave]

Needs #5531 merged first.

[firewave]

I did not clean up any unmatched inline suppressions. I would like to hold that off until https://trac.cppcheck.net/ticket/12070 is implemented. Unfortunately the suppression code gives me headaches (even more than usual) so I didn't take a stab at it yet. Those messages would also not show up until #3090 is merged.

[danmar]

looks ok to me. I don't feel strongly about those shadowFunction.. it is a bit of a code smell to shadow a function but on the other hand it's also good to use the optimal name for a variable. if we use an unoptimal name for a variable that is not good.

[firewave]

looks ok to me. I don't feel strongly about those shadowFunction.. it is a bit of a code smell to shadow a function but on the other hand it's also good to use the optimal name for a variable. if we use an unoptimal name for a variable that is not good.

That's why I didn't try to fix them - yet. Will do in an upcoming PR.

In general if there are warnings we do not want to address in our code we should no reporting them. IMO this does not apply to this warning.

On a side note - it seems no compiler warns about this.