Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include GUI test sources in selfcheck #5687

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave changed the title removed unnecessary file pattern for GUI sources in selfcheck - GUI tests are now included include GUI test sources in selfcheck Nov 20, 2023
@firewave
Copy link
Collaborator Author

Will update after #5703 was merged.

@firewave firewave marked this pull request as ready for review December 1, 2023 15:07
@firewave
Copy link
Collaborator Author

firewave commented Dec 1, 2023

I added those as there's a passedByValue false negative in testcppchecklibrary. Also more dogfooding is always good.

I did suppress the naming-privateMemberVariable warnings since they would have caused almost all lines in the source to be changed.

The uninitMemberVar are not of interest since the classes are simply mocked.

@@ -20,7 +20,9 @@

#include "addoninfo.h"
#include "importproject.h"
// cppcheck-suppress-begin uninitMemberVar
#include "platform.h"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to suppress all the warnings from an include. I would expect this to work but it doesn't as it was probably not intended to be used that way. I will file a ticket about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants