-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up signal handler and improved stack trace generation #5581
Conversation
This needs actual unit tests for the stack trace code. I have been meaning to do this for quite a while since they different in format between Windows and Linux. Also to leverage them in daca instead of calling |
3fc8c18
to
80d4aa7
Compare
This omits all frames above our own code now without adjusting the frame number:
I guess I will make this behavior optional in case the code needs to show all frames in the future. |
0e21bd6
to
533669b
Compare
…made it re-usable
…ed stacktrace generation
See #5540 (review) for related discussion.