Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not explicitly load windows.cfg during command-line parsing #5613

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Nov 2, 2023

As we now fail early on loading of all libraries we no longer need to explicitly bail out on mandatory ones. This would have also caused libraries and library to go out-of-sync and possibly lead to duplicated loading of the library. It also allows for a CppCheckExecutor to be made private.

@firewave
Copy link
Collaborator Author

firewave commented Nov 2, 2023

The remaining public functions of CppCheckExecutor will most likely go away with #5581. After that we can move most of the implementation inside the source file so less details are spilled.

@danmar danmar merged commit df860a9 into danmar:main Nov 4, 2023
74 checks passed
@firewave firewave deleted the cppchechex-priv branch November 4, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants