Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): use inject to pass container reference to selectableItem #169

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat(lib): use inject to pass container reference to selectableItem #169

wants to merge 19 commits into from

Commits on Nov 28, 2022

  1. fix(lib): start selection inbetween select items 

    This commit fixes the issue of not being able to start a selection if
mousedown occured on neither Host element nor select item element
but inbetween. The issue occurs if `SelectItem`s are not direct children
of the `SelectContainer`.

Fixes d3lm#144
    @odermattaccso
    odermattaccso committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    308a731 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. feat(lib): use inject to pass container reference to selectableItem

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    22ea2cc View commit details
    Browse the repository at this point in the history

  2. docs: added nested directive demo with drag and drop 

    refactor: removed dead code from change and fixed circular dependency caused by DI
    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f08cae2 View commit details
    Browse the repository at this point in the history

  3. style: fixed lint error for member ordering

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    132e52a View commit details
    Browse the repository at this point in the history

  4. docs: added new section to README

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    907488d View commit details
    Browse the repository at this point in the history

  5. docs(lib): added section to readme about components capturing events 

    test(app): added cypress test for new example demo
    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    750c669 View commit details
    Browse the repository at this point in the history

  6. fix(lib): new Token was not export with the public api

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f14b9f9 View commit details
    Browse the repository at this point in the history

  7. refactor(app): renamed drag-and-drop 

    docs: updated grammar
    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f21b63e View commit details
    Browse the repository at this point in the history

  8. refactor(app): forgot to add new files

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    22f82aa View commit details
    Browse the repository at this point in the history

  9. style: updated cypress comments 

    style: update whitespace
    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    7aaf934 View commit details
    Browse the repository at this point in the history

  10. refactor(app): moved drag-and-drop above mobile and hides 

    style(app): linting some scss
    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    69b9cde View commit details
    Browse the repository at this point in the history

  11. fix(app): fixed cypress test, error with test

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    56a1f77 View commit details
    Browse the repository at this point in the history

  12. fix(app): visual issues with hidden placeholders

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    6960d4c View commit details
    Browse the repository at this point in the history

  13. style(app): trying to force tests to re-run

    @odermattaccso
    Brian Kimball authored and odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    68bf5b7 View commit details
    Browse the repository at this point in the history

  14. test(lib): fixed bug when running all tests 

    For some reason `itemDeselected` emits another event after Jest starts
cleaning up the test component which resulted in a failing `expect`
    @odermattaccso
    odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f0a11a9 View commit details
    Browse the repository at this point in the history

  15. fix(app): disable selectOnClick and dragOverItems to make drag work

    @odermattaccso
    odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    d695b83 View commit details
    Browse the repository at this point in the history

  16. fix(lib): use internal memory of currentlyselected items 

    If `selectedItems` has not two-way binding by an outside component then
it will not contain a list of the currently selected items
    @odermattaccso
    odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b558485 View commit details
    Browse the repository at this point in the history

  17. refactor(lib): remove debugging output

    @odermattaccso
    odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    619943a View commit details
    Browse the repository at this point in the history

  18. test: fixed 'element is currently animating' issue in headless e2e tests

    @odermattaccso
    odermattaccso committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    40316b1 View commit details
    Browse the repository at this point in the history