Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): use inject to pass container reference to selectableItem #169

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

PhOder
Copy link

@PhOder PhOder commented Dec 2, 2022

In this PR I updated the work in #112 fixed some failing tests.

Attention this PR includes the work of #167

odermattaccso and others added 19 commits November 28, 2022 01:07
This commit fixes the issue of not being able to start a selection if
mousedown occured on neither Host element nor select item element
but inbetween. The issue occurs if `SelectItem`s are not direct children
of the `SelectContainer`.

Fixes d3lm#144
refactor: removed dead code from change and fixed circular dependency caused by DI
test(app): added cypress test for new example demo
style: update whitespace
For some reason `itemDeselected` emits another event after Jest starts
cleaning up the test component which resulted in a failing `expect`
If `selectedItems` has not two-way binding by an outside component then
it will not contain a list of the currently selected items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants