Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support migrating from Maker CDPs #44

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support migrating from Maker CDPs #44

wants to merge 7 commits into from

Commits on Oct 26, 2022

  1. Initial implementation of Maker CDP migration without new unit tests

    @kevincheng96
    kevincheng96 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e593814 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Set up first passing unit tests for Maker integration

    @kevincheng96
    kevincheng96 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    082f548 View commit details
    Browse the repository at this point in the history

  2. Fix implementation for max repay for CDP; add more tests

    @kevincheng96
    kevincheng96 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    42da5c5 View commit details
    Browse the repository at this point in the history

  3. Update spec

    @kevincheng96
    kevincheng96 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e2ef769 View commit details
    Browse the repository at this point in the history

  4. Fix extra indent in spec

    @kevincheng96
    kevincheng96 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    11d6fb9 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Require user to have permission to modify CDP; don't supply collatera… 

    …l to Comet if amount is 0
    @kevincheng96
    kevincheng96 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d14c2d1 View commit details
    Browse the repository at this point in the history

  2. Get rid of a local var to fix stack too deep when running coverage

    @kevincheng96
    kevincheng96 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    57e3735 View commit details
    Browse the repository at this point in the history