Support migrating from Maker CDPs #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflatow
reviewed
Oct 27, 2022
…l to Comet if amount is 0
|
Pushed up two more changes:
|
jflatow
reviewed
Oct 28, 2022
| - **REVERT** `UnauthorizedCDP(cdpId)` | ||
| - **WHEN** `borrowAmount == type(uint256).max`: | ||
| - **BIND READ** `repayAmount = getVaultDebt(vat, ilk, urn)` | ||
| - **BIND READ** `(, dart) = -vat.urns(ilk, urn)` |
jflatow
reviewed
Oct 28, 2022
| withdrawAmount = position.collateralAmount; | ||
|
|
||
| // **BIND** `withdrawAmount18 = collateralAmount * (10 ** (18 - gemJoin.dec()))` | ||
| withdrawAmount18 = position.collateralAmount * (10 ** (18 - position.gemJoin.dec())); |
There was a problem hiding this comment.
This is kinda tricky, some more commentary on why these decimal conversions are correct might be useful for posterity
jflatow
reviewed
Oct 28, 2022
| dart = signed256(amount * RAY / rate); | ||
| // Checks the calculated dart is not higher than urn.art (total debt), otherwise uses its value | ||
| dart = uint256(dart) <= art ? -dart : -signed256(art); | ||
| } |
There was a problem hiding this comment.
On the verge of wondering if it would make sense to separate 'modules' into contracts e.g. w/ the Maker structs / helpers defined separately?
jflatow
reviewed
Oct 28, 2022
| CometMigratorV2.CDPPosition[] memory cdpPosition = new CometMigratorV2.CDPPosition[](1); | ||
| cdpPosition[0] = CometMigratorV2.CDPPosition({ | ||
| cdpId: cdpIds[0], | ||
| collateralAmount: 100e18, // XXX withdrawing all without max doesn't work due to dust |
There was a problem hiding this comment.
So can't exit the CDP with dust remaining?
jflatow
reviewed
Oct 28, 2022
| @@ -7,6 +7,9 @@ import "forge-std/Test.sol"; | |||
| import "./MainnetConstantsV2.t.sol"; | |||
|
|
|||
| contract Positor is Test, MainnetConstants { | |||
| // Units used in Maker contracts | |||
| uint256 internal constant RAY = 10**27; | |||
|
|
|||
| // XXX change name to `PositCompoundV2`? | |||
jflatow
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to Migrator 2.0 for migrating from Maker CDPs. I've also updated the spec to be up-to-date with the implementation.