Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant deps #108

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Remove redundant deps #108

merged 3 commits into from
Apr 1, 2024

Conversation

willtebbutt
Copy link
Member

#105 points out that there appear to be redundant deps. This PR will remove them if it is in fact the case that they are unused.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Performance Ratio:

┌────────────────────────────┬────────┬─────────┬─────────────┬─────────┐
│                      Label │  Tapir │  Zygote │ ReverseDiff │  Enzyme │
│                     String │ String │  String │      String │  String │
├────────────────────────────┼────────┼─────────┼─────────────┼─────────┤
│                        sum │  138.0 │   0.784 │        3.15 │   0.713 │
│                       _sum │   25.5 │   500.0 │        27.0 │   0.121 │
│                   kron_sum │  201.0 │    3.59 │       205.0 │    25.3 │
│              kron_view_sum │  254.0 │    11.6 │       231.0 │    8.68 │
│      naive_map_sin_cos_exp │   8.38 │ missing │        8.74 │    2.78 │
│            map_sin_cos_exp │   10.8 │    1.69 │         7.5 │    3.36 │
│      broadcast_sin_cos_exp │   9.69 │    2.54 │        1.63 │     2.8 │
│                 simple_mlp │   24.8 │    3.13 │        12.2 │    3.88 │
│                     gp_lml │   43.1 │    4.19 │     missing │ missing │
│ turing_broadcast_benchmark │   19.6 │ missing │        33.5 │ missing │
└────────────────────────────┴────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 513f57d into main Apr 1, 2024
12 checks passed
@willtebbutt willtebbutt deleted the wct/remove-redundant-deps branch April 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant