Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the dependence on BenchmarkTools? #105

Closed
gdalle opened this issue Mar 29, 2024 · 6 comments
Closed

Why the dependence on BenchmarkTools? #105

gdalle opened this issue Mar 29, 2024 · 6 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Mar 29, 2024

I looked for @b in the package and it only shows up in benchmarking or testing. Any reason to keep BenchmarkTools in the package's dependencies?

@gdalle
Copy link
Collaborator Author

gdalle commented Mar 29, 2024

Presumably the same goes for the Profile stdlib

@willtebbutt
Copy link
Member

Good catch, must be an oversight on my part. Will deal with this at some point 👍

@willtebbutt
Copy link
Member

Presumably the same goes for the Profile stdlib

Where abouts in the code did you find the Profile stdlib dep? I can't seem to find it in the code.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 1, 2024

Adding Tapir to my test environment back when it wasn't registered happened after instantiation, and so I saw all the packages that were added to the manifest. The ones that struck me as out of place were Profile and BenchmarkTools, but maybe Profile was an indirect dependency (eg of BenchmarkTools), I didn't double-check.

@willtebbutt
Copy link
Member

Cool -- yeah, I think you're correct re Profile being an indirect dep of Tapir. Thanks for confirming.

@willtebbutt
Copy link
Member

Resolved by #108 . Thanks for catching this @gdalle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants