Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NGINX ProxyManager (Install / Update) #763

Closed
wants to merge 2 commits into from
+6 −6
Closed

Fix NGINX ProxyManager (Install / Update) #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b6b5f
Update nginxproxymanager-install.sh
MickLesk Dec 10, 2024
20e9aa3
Fix Update Script
MickLesk Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ct/nginxproxymanager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ function update_script() {

msg_info "Building Frontend"
cd ./frontend
pnpm install &>/dev/null
pnpm upgrade &>/dev/null
pnpm run build &>/dev/null
yarn cache clean --silent --force &>/dev/null
yarn install --silent --network-timeout=30000 &>/dev/null
yarn build &>/dev/null
cp -r dist/* /app/frontend
cp -r app-images/* /app/frontend/images
msg_ok "Built Frontend"
Expand Down
6 changes: 3 additions & 3 deletions install/nginxproxymanager-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ msg_ok "Set up Enviroment"

msg_info "Building Frontend"
cd ./frontend
$STD pnpm install
$STD pnpm upgrade
$STD pnpm run build
$STD yarn cache clean --silent --force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? Where is yarn installed? pnpm install section is not removed? tteck/Proxmox@edf3803#diff-e676f31f25717f8123cc0904ec5973dee3dc53b86e2b0ff7bec0eeb72c6ce82fR132

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you can run the bash script against the develop Branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NginxProxyManager/nginx-proxy-manager/blob/b3de76c945b087b9a585faff128ca655170f8ea1/docker/Dockerfile#L44-L47

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ Stopped Services
✓ Cleaned Old Files
✓ Downloaded NPM v2.12.1
✓ Setup Enviroment
/ Building Frontend
[ERROR] in line 143: exit code 0: while executing command yarn cache clean --silent --force &> /dev/null

running against the dev branch ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Work on my systems fine :D fck NPM

Copy link
Contributor

@havardthom havardthom Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NginxProxyManager/nginx-proxy-manager/blob/b3de76c945b087b9a585faff128ca655170f8ea1/docker/Dockerfile#L44-L47

That is backend install, not the same as frontend install which you are changing in this PR. Frontend in that dockerfile is prebuilt (COPY frontend/dist /app/frontend)

$STD yarn install --silent --network-timeout=30000
$STD yarn build
cp -r dist/* /app/frontend
cp -r app-images/* /app/frontend/images
msg_ok "Built Frontend"
Expand Down
Loading