-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NGINX ProxyManager (Install / Update) #763
base: main
Are you sure you want to change the base?
Conversation
$STD pnpm install | ||
$STD pnpm upgrade | ||
$STD pnpm run build | ||
$STD yarn cache clean --silent --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this? Where is yarn installed? pnpm install section is not removed? tteck/Proxmox@edf3803#diff-e676f31f25717f8123cc0904ec5973dee3dc53b86e2b0ff7bec0eeb72c6ce82fR132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you can run the bash script against the develop Branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✓ Stopped Services
✓ Cleaned Old Files
✓ Downloaded NPM v2.12.1
✓ Setup Enviroment
/ Building Frontend
[ERROR] in line 143: exit code 0: while executing command yarn cache clean --silent --force &> /dev/null
running against the dev branch ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol. Work on my systems fine :D fck NPM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is backend install, not the same as frontend install which you are changing in this PR. Frontend in that dockerfile is prebuilt (COPY frontend/dist /app/frontend
)
Why is this thing dying with every update? |
This script just sucks. There's something new every time |
Description
Reverted deprecated pnpm in frontend, switched to official yarn
Fixes #761
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here: