Accept i18n errors #684
Accept i18n errors #684
Conversation
| @@ -18,16 +21,22 @@ | |||
| * @param message error message | |||
| * @return the error message localized and formatted | |||
| */ | |||
| String format(final List<Locale> locales, final String message); | |||
| String format(final List<Locale> locales, final String message, final Map<String, Object> hashArgs); | |||
There was a problem hiding this comment.
I would prefer the parameter name args here.
There was a problem hiding this comment.
I named them hashArgs here and in I18nResolver because they are hash arguments. What don't you like in particular from the name?
There was a problem hiding this comment.
Since the type of hashArgs is just Map, I was wondering how useful it is to mention hash in the parameter name.
| @@ -35,7 +32,7 @@ public void extractErrors() throws Exception { | |||
|
|
|||
| private void checkError(ErrorBean error, String field, String key, String message) { | |||
There was a problem hiding this comment.
I didn't check it in the IDE, but to me it looks the key parameter is unused?
| import static org.mockito.Mockito.when; | ||
|
|
||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class ErrorFormatterImplTest { |
| @@ -18,16 +21,22 @@ | |||
| * @param message error message | |||
| * @return the error message localized and formatted | |||
| */ | |||
| String format(final List<Locale> locales, final String message); | |||
| String format(final List<Locale> locales, final String message, final Map<String, Object> hashArgs); | |||
|
@lauraluiz i like what has been done in general, there is major quality amelioration that can be done and that i think is worth the effort, which is to work with generated classes like the android WDYT? |
|
Having type-safe messages sounds really interesting @acbeni ! I hadn't thought of that solution. Could you please create an issue for that? I would address that after v1.0.0 though. |
|
And actually all theme resources might benefit from it. |
|
@lauraluiz i created issue to follow up #685 |
All error messages can be localized now.
The ones defined in Sunrise are located in the bundle "messages" (as shows the
messages.yamlfiles). The ones pre-defined by Play (i.e. https://github.com/playframework/playframework/blob/2.5.18/framework/src/play/src/main/resources/messages.default) are located in the default bundle ("main" if not changed). They can also be localized using the default Play way of creating messages files for each language.