Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I18n TODOs in pre-v1.0.0 #605

Closed
katmatt opened this issue May 10, 2017 · 3 comments
Closed

Fix I18n TODOs in pre-v1.0.0 #605

katmatt opened this issue May 10, 2017 · 3 comments

Comments

@katmatt
Copy link
Contributor

katmatt commented May 10, 2017 •
edited
Loading

We should add i18n for the // TODO i18n comments.
@katmatt
Copy link
Contributor Author

katmatt commented May 12, 2017

Duplicates #386

@Valerzen88
Copy link

Hello,
is any progress at that fix after 5 month? Our customer needs this to be changed in the next days...

Especially it should be changed in the following methods:

  • SunriseSignUpController.handleClientErrorFailedAction()
  • SunriseFrameworkController.saveUnexpectedFormError()
  • SunriseLogInController.handleClientErrorFailedAction()

Regards,
Valeri

@lauraluiz lauraluiz changed the title Fix I18n TODOs Fix I18n TODOs in pre-v1.0.0 Oct 12, 2017
@lauraluiz
Copy link
Contributor

solved #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@katmatt @lauraluiz @Valerzen88