Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1469 Update misc NC (+ global) copy #5285

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ def edit
@department_of_taxation = StateFile::StateInformationService.department_of_taxation(current_state_code)
@department_of_taxation_initials = @department_of_taxation.split(" ").map(&:first).join.upcase
@tax_refund_url = StateFile::StateInformationService.tax_refund_url(current_state_code)
@tax_payment_url = StateFile::StateInformationService.tax_payment_url(current_state_code)
@tax_payment_info_text = StateFile::StateInformationService.tax_payment_info_text(current_state_code)
@tax_payment_info_url = StateFile::StateInformationService.tax_payment_info_url(current_state_code)
@voucher_form_name = StateFile::StateInformationService.voucher_form_name(current_state_code)
@mail_voucher_address = StateFile::StateInformationService.mail_voucher_address(current_state_code)
@voucher_path = StateFile::StateInformationService.voucher_path(current_state_code)
Expand Down
16 changes: 8 additions & 8 deletions app/services/state_file/state_information_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class StateInformationService
:submission_type,
:survey_link,
:tax_payment_info_url,
:tax_payment_url,
:tax_payment_info_text,
:tax_refund_url,
:timezone,
:vita_link_en,
Expand Down Expand Up @@ -76,8 +76,8 @@ def state_intake_class_names
submission_builder_class: SubmissionBuilder::Ty2022::States::Az::AzReturnXml,
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_0v0BnYNRoLIqzhY",
submission_type: "Form140",
tax_payment_info_text: "https://azdor.gov/make-payment-online",
tax_payment_info_url: "https://azdor.gov/making-payments-late-payments-and-filing-extensions",
Copy link
Contributor Author

@arinchoi03 arinchoi03 Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the app/views/state_file/questions/taxes_owed/edit.html.erb implementation, looks like tax_payment_url is the link text and tax_payment_info_url is the actual link we want to navigate to. This was not being used in the return_status, so making that consistent

Q here waiting on confirmation from Madison

tax_payment_url: "https://azdor.gov/make-payment-online",
tax_refund_url: "https://aztaxes.gov/home/checkrefund",
department_of_taxation: "Arizona Department of Revenue",
timezone: 'America/Phoenix',
Expand Down Expand Up @@ -105,8 +105,8 @@ def state_intake_class_names
submission_type: "Form40",
submission_builder_class: SubmissionBuilder::Ty2024::States::Id::IdReturnXml,
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_0URdKLyW7K53rZc",
tax_payment_info_text: "https://tax.idaho.gov/e-pay/",
tax_payment_info_url: "https://tax.idaho.gov/online-services/e-pay/",
tax_payment_url: "https://tax.idaho.gov/e-pay/",
tax_refund_url: "https://tax.idaho.gov/taxes/income-tax/individual-income/refund/",
department_of_taxation: "Idaho State Tax Commission",
timezone: 'America/Boise',
Expand Down Expand Up @@ -135,8 +135,8 @@ def state_intake_class_names
submission_type: "MD502",
submission_builder_class: SubmissionBuilder::Ty2024::States::Md::MdReturnXml,
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_24BAmNMNrpkhLwy",
tax_payment_info_text: "Marylandtaxes.gov",
tax_payment_info_url: "https://www.marylandtaxes.gov/individual/individual-payments.php",
tax_payment_url: "Marylandtaxes.gov",
tax_refund_url: "https://interactive.marylandtaxes.gov/INDIV/refundstatus/home.aspx",
department_of_taxation: "Comptroller of Maryland",
timezone: 'America/New_York',
Expand Down Expand Up @@ -164,10 +164,10 @@ def state_intake_class_names
submission_type: "FormNCD400",
submission_builder_class: SubmissionBuilder::Ty2024::States::Nc::NcReturnXml,
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_1MM0vBfZ5N2OMLA",
tax_payment_info_text: "NCDOR.gov",
tax_payment_info_url: "https://www.ncdor.gov/file-pay/pay-individual-income-tax",
tax_payment_url: "https://www.ncdor.gov/file-pay/pay-individual-income-tax",
tax_refund_url: "https://eservices.dor.nc.gov/wheresmyrefund/SelectionServlet",
department_of_taxation: "North Carolina Department of Revenue",
department_of_taxation: "N.C. Department of Revenue",
Copy link
Contributor Author

@arinchoi03 arinchoi03 Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timezone: 'America/New_York',
vita_link_en: "https://airtable.com/appqG5OGbTLBiQ408/pagJPN5iPinERGb3Q/form",
vita_link_es: "https://airtable.com/appqG5OGbTLBiQ408/pagS982AjKEml809R/form",
Expand All @@ -193,8 +193,8 @@ def state_intake_class_names
pay_taxes_link: "https://www.nj.gov/treasury/taxation/payments-notices.shtml",
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_82CJgtfW0HFEPIi",
submission_type: "Resident",
tax_payment_info_text: "https://www.nj.gov/treasury/taxation/payments-notices.shtml",
tax_payment_info_url: "https://www.nj.gov/treasury/taxation/payments-notices.shtml",
tax_payment_url: "https://www.nj.gov/treasury/taxation/payments-notices.shtml",
tax_refund_url: "https://www.tax.ny.gov/pit/file/refund.htm",
department_of_taxation: "New Jersey Division of Taxation",
timezone: 'America/New_York',
Expand Down Expand Up @@ -223,8 +223,8 @@ def state_intake_class_names
software_id_key: "sin",
submission_builder_class: SubmissionBuilder::Ty2022::States::Ny::NyReturnXml,
survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_3pXUfy2c3SScmgu",
tax_payment_info_text: "Tax.NY.gov",
tax_payment_info_url: "https://www.tax.ny.gov/pay/ind/pay-income-tax-online.htm",
tax_payment_url: "Tax.NY.gov",
tax_refund_url: "https://www.tax.ny.gov/pit/file/refund.htm",
department_of_taxation: "",
timezone: 'America/New_York',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,33 @@
<div class="spacing-below-25">
<%=t('.public_school_tax_credit_heading_html') %>
<ul>
<li><%=t('.public_school_tax_credit_paid_fees') %></li>
<li><%=t('.public_school_tax_credit_provide_info_html') %></li>
</ul>
</div>
<div class="reveal">
<p><button class="reveal__button"><%= t("state_file.questions.eligible.edit.credits_not_supported")%></button></p>

<div class="spacing-below-25 with-top-separator">
<%=t('.property_tax_credit_heading_html') %>
<ul>
<li><%=t('.property_tax_credit_age') %></li>
<li><%=t('.property_tax_credit_income') %></li>
<li><%=t('.property_tax_credit_paid') %></li>
</ul>
</div>
<div class="reveal__content">
<div class="spacing-below-25">
<%=t('.public_school_tax_credit_heading_html') %>
<ul>
<li><%=t('.public_school_tax_credit_paid_fees') %></li>
<li><%=t('.public_school_tax_credit_provide_info_html') %></li>
</ul>
</div>

<div class="spacing-below-25 with-top-separator">
<%=t('.other_credits_heading') %>
<ul>
<li><%=t('.other_credits_529_html') %></li>
<li><%=t('.other_credits_301_html') %></li>
<li><%=t('.other_credits_itemized_deductions') %></li>
<li><%=t('.other_credits_add_dependents') %></li>
<li><%=t('.other_credits_change_filing_status') %></li>
</ul>
<div class="spacing-below-25 with-top-separator">
<%=t('.property_tax_credit_heading_html') %>
<ul>
<li><%=t('.property_tax_credit_age') %></li>
<li><%=t('.property_tax_credit_income') %></li>
<li><%=t('.property_tax_credit_paid') %></li>
</ul>
</div>

<div class="spacing-below-25 with-top-separator">
<%=t('.other_credits_heading') %>
<ul>
<li><%=t('.other_credits_529_html') %></li>
<li><%=t('.other_credits_301_html') %></li>
<li><%=t('.other_credits_itemized_deductions') %></li>
<li><%=t('.other_credits_add_dependents') %></li>
<li><%=t('.other_credits_change_filing_status') %></li>
</ul>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
<div class="spacing-below-25">
<ul>
<li><%=t('.id_college_savings_program') %></li>
<li><%=t('.id_youth_rehab_contributions') %></li>
<li><%=t('.maintaining_elderly_disabled_credit') %></li>
<li><%=t('.long_term_care_insurance_subtraction') %></li>
<li><%=t('.earned_on_reservation') %></li>
<li><%=t('.education_contribution_credit') %></li>
<li><%=t('.itemized_deductions') %></li>
<li><%=t('.dependents_not_claimed_fed_return') %></li>
<li><%=t('.voluntary_donations') %></li>
<li><%=t('.change_in_filing_status') %></li>
</ul>
<div class="reveal">
<p><button class="reveal__button"><%= t("state_file.questions.eligible.edit.credits_not_supported")%></button></p>
<div class="reveal__content spacing-below-25">
<ul>
<li><%=t('.id_college_savings_program') %></li>
<li><%=t('.id_youth_rehab_contributions') %></li>
<li><%=t('.maintaining_elderly_disabled_credit') %></li>
<li><%=t('.long_term_care_insurance_subtraction') %></li>
<li><%=t('.earned_on_reservation') %></li>
<li><%=t('.education_contribution_credit') %></li>
<li><%=t('.itemized_deductions') %></li>
<li><%=t('.dependents_not_claimed_fed_return') %></li>
<li><%=t('.voluntary_donations') %></li>
<li><%=t('.change_in_filing_status') %></li>
</ul>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
<div>
<ul class="list--bulleted">
<li><%=t('.personal_education') %></li>
<li><%=t('.college_savings_account')%></li>
<li><%=t('.extension_payment')%></li>
<li><%=t('.estimated_income_tax_payments') %></li>
<li><%=t('.credits_for_rehabilitating') %></li>
<li><%=t('.credits_carried') %></li>
</ul>
<div class="reveal">
<p><button class="reveal__button"><%= t(".credits_not_supported")%></button></p>
<div class="reveal__content">
<ul class="list--bulleted">
<li><%=t('.personal_education') %></li>
<li><%=t('.college_savings_account')%></li>
<li><%=t('.extension_payment')%></li>
<li><%=t('.estimated_income_tax_payments') %></li>
<li><%=t('.credits_for_rehabilitating') %></li>
<li><%=t('.credits_carried') %></li>
</ul>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -1,30 +1,36 @@
<div class="spacing-below-25">
<ul>
<li><a href="https://www.tax.ny.gov/pit/credits/child_and_dependent_care_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.nys_child_dependent_care_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/real_property_tax_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.real_property_tax_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/college_tuition_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.college_tuition_credit') %></a></li>
<li><%=t('.non_custodial_nys_eic_html') %></li>
<li><a href="https://www.tax.ny.gov/pit/credits/volunteerfirefighters.htm" target="_blank" rel="noopener nofollow"><%=t('.firefighter_ambulance_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/longterm_care_insurance_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.long_term_care_credit') %></a></li>
</ul>
</div>
<div class="reveal">
<p><button class="reveal__button"><%= t("state_file.questions.eligible.edit.credits_not_supported")%></button></p>

<div class="spacing-below-25 with-top-separator">
<%=t('.subtractions_225_heading_html') %>
<ul>
<li><%=t('.subtractions_225_military') %></li>
<li><%=t('.subtractions_225_native_american') %></li>
<li><%=t('.subtractions_225_help_loan') %></li>
<li><%=t('.subtractions_225_student_loan') %></li>
<li><%=t('.subtractions_225_health_care_worker') %></li>
</ul>
</div>
<div class="reveal__content">
<div class="spacing-below-25">
<ul>
<li><a href="https://www.tax.ny.gov/pit/credits/child_and_dependent_care_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.nys_child_dependent_care_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/real_property_tax_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.real_property_tax_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/college_tuition_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.college_tuition_credit') %></a></li>
<li><%=t('.non_custodial_nys_eic_html') %></li>
<li><a href="https://www.tax.ny.gov/pit/credits/volunteerfirefighters.htm" target="_blank" rel="noopener nofollow"><%=t('.firefighter_ambulance_credit') %></a></li>
<li><a href="https://www.tax.ny.gov/pit/credits/longterm_care_insurance_credit.htm" target="_blank" rel="noopener nofollow"><%=t('.long_term_care_credit') %></a></li>
</ul>
</div>

<div class="spacing-below-25 with-top-separator">
<%=t('.other_credits_heading') %>
<ul>
<li><%=t('.other_credits_itemized_deductions') %></li>
<li><%=t('.other_credits_change_filing_status') %></li>
<li><%=t('.other_credits_est_tax_etc') %></li>
</ul>
<div class="spacing-below-25 with-top-separator">
<%=t('.subtractions_225_heading_html') %>
<ul>
<li><%=t('.subtractions_225_military') %></li>
<li><%=t('.subtractions_225_native_american') %></li>
<li><%=t('.subtractions_225_help_loan') %></li>
<li><%=t('.subtractions_225_student_loan') %></li>
<li><%=t('.subtractions_225_health_care_worker') %></li>
</ul>
</div>

<div class="spacing-below-25 with-top-separator">
<%=t('.other_credits_heading') %>
<ul>
<li><%=t('.other_credits_itemized_deductions') %></li>
<li><%=t('.other_credits_change_filing_status') %></li>
<li><%=t('.other_credits_est_tax_etc') %></li>
</ul>
</div>
</div>
</div>
7 changes: 1 addition & 6 deletions app/views/state_file/questions/eligible/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@
<% if current_state_code == "md" %>
<%= render partial: "state_file/questions/eligible/md_reveals" %>
<% else %>
<div class="reveal">
<p><button class="reveal__button"><%= t(".credits_not_supported")%></button></p>
<div class="reveal__content">
<%= render partial: "state_file/questions/eligible/#{current_state_code}_credits_unsupported" %>
</div>
</div>
<%= render partial: "state_file/questions/eligible/#{current_state_code}_credits_unsupported" %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reveal__button text is something different for nc now, so making it go into the respective partials seemed like a good solution


<div class="reveal">
<p><button class="reveal__button"><%= t('.not_supported') %></button></p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<% # i18n-tasks-use t('state_file.questions.return_status.accepted.refund_details_html') # hint for the i18n linter that, yes, we are using this key (sometimes) %>
<p><%= t(".#{current_state_code}.refund_details_html", default: :'.refund_details_html', website_name: @department_of_taxation_initials, tax_refund_url: @tax_refund_url) %></p>
<% elsif refund_or_owed_amount.negative? %>
<p><%= t('.direct_debit_html', tax_payment_url: @tax_payment_url) %></p>
<p><%= t('.direct_debit_html', tax_payment_info_text: @tax_payment_info_text, tax_payment_info_url: @tax_payment_info_url) %></p>
<% end %>

<hr class="spacing-above-25 spacing-below-25"/>
Expand Down
2 changes: 1 addition & 1 deletion app/views/state_file/questions/taxes_owed/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{ value: :direct_deposit, label: t(".pay_bank"), input_html: { "data-follow-up": "#pay-from-bank" } },
{ value: :mail, label: t(".pay_mail_online_html",
tax_payment_info_url: StateFile::StateInformationService.tax_payment_info_url(current_state_code),
tax_payment_info_text: StateFile::StateInformationService.tax_payment_url(current_state_code),
tax_payment_info_text: StateFile::StateInformationService.tax_payment_info_text(current_state_code),
) },
]
) %>
Expand Down
7 changes: 4 additions & 3 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2637,6 +2637,7 @@ en:
college_savings_account: 529 College Savings Account Contributions
credits_carried: Credits carried forward from previous years
credits_for_rehabilitating: Credits for Rehabilitating Historic Structures
credits_not_supported: What credits and deductions does this service not support this year?
estimated_income_tax_payments: Estimated income tax payments
extension_payment: Extension payments
personal_education: Personal Education Student Account Deposits Deduction
Expand Down Expand Up @@ -3548,7 +3549,7 @@ en:
<li>
Make your check or money order payable to %{payable_to}. Write your full SSN or ITIN, “%{filing_year} Tax”, and "Form %{form_number}" on your payment.
</li>
direct_debit_html: If you have a remaining tax balance, remember to <strong>pay it online at <a target="_blank" rel="noopener nofollow" href="%{tax_payment_url}">%{tax_payment_url}</a></strong> or by mail before the April 15 filing deadline.
direct_debit_html: If you have a remaining tax balance, remember to <strong>pay it online at <a target="_blank" rel="noopener nofollow" href="%{tax_payment_info_url}">%{tax_payment_info_text}</a></strong> or by mail before the April 15 filing deadline.
download_voucher: Download payment voucher form
feedback: We value your feedback—let us know what you think of this service.
include_payment: You'll need to include the payment voucher form.
Expand Down Expand Up @@ -3664,8 +3665,8 @@ en:
routing_number: Routing Number
withdraw_amount: How much do you authorize to be withdrawn from your account? (Your total amount due is&#58; $%{owed_amount}.)
edit:
direct_deposit: Direct deposit (fastest)
mail: Mail my payment (slower)
direct_deposit: By direct deposit (fastest)
mail: By mail (slower)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recognizing this is a cross-state change, asking if this is what we want for all states:

Q Here

page_title: Good news, you're getting a tax refund. How would you like to receive your refund?
title_html: Good news, you're getting a %{state_name} state tax refund of <strong>$%{refund_amount}.</strong>
taxes_owed:
Expand Down
3 changes: 2 additions & 1 deletion config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2593,6 +2593,7 @@ es:
college_savings_account: Contribuciones a cuentas de ahorro 529 para la universidad
credits_carried: Créditos acumulados de años anteriores
credits_for_rehabilitating: Créditos por la rehabilitación de estructuras históricas
credits_not_supported: What credits and deductions does this service not support this year?
estimated_income_tax_payments: Pagos de impuestos sobre la renta estimados
extension_payment: Pagos por extensión
personal_education: Deducción por depósitos en cuentas de estudiante de educación personal
Expand Down Expand Up @@ -3522,7 +3523,7 @@ es:
<li>
Haz tu cheque o giro postal a nombre del %{payable_to}. Escribe tu SSN o ITIN completo, "%{filing_year} Tax", y "Form %{form_number}" en tu pago.
</li>
direct_debit_html: Si tienes un saldo de impuestos pendiente, recuerda <strong>pagarlo en línea en <a target="_blank" rel="noopener nofollow" href="%{tax_payment_url}">%{tax_payment_url}</a></strong> o por correo antes de la fecha límite de declaración que es el 15 de abril.
direct_debit_html: Si tienes un saldo de impuestos pendiente, recuerda <strong>pagarlo en línea en <a target="_blank" rel="noopener nofollow" href="%{tax_payment_info_url}">%{tax_payment_info_text}</a></strong> o por correo antes de la fecha límite de declaración que es el 15 de abril.
download_voucher: Descargar el formulario de comprobante de pago
feedback: Valoramos sus comentarios; háganos saber lo que piensa de esta herramienta.
include_payment: Debes incluir el formulario de comprobante de pago.
Expand Down
Loading
Loading